Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20171118134545.25784-1-christophe.jaillet@wanadoo.fr>
References: <20171118134545.25784-1-christophe.jaillet@wanadoo.fr>
From:   PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
Date:   Mon, 20 Nov 2017 20:39:48 +0530
Message-ID: <CANc+2y6kih23rAmDg6eqrGQDWAj3iM7_b40KS77QpB-M2Vd76g@mail.gmail.com>
Subject: Re: [PATCH] crypto: hifn_795x - Fix a memory leak in the error
 handling path of 'hifn_probe()'
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>,
        "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Christophe,

On 18 November 2017 at 19:15, Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
> 'dev' is leaking in the error handling path of 'hifn_probe()'.
>
> Add a 'kfree(dev)' to match the code in 'hifn_remove()'
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/crypto/hifn_795x.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/hifn_795x.c b/drivers/crypto/hifn_795x.c
> index e09d4055b19e..a5a36fe7bf2c 100644
> --- a/drivers/crypto/hifn_795x.c
> +++ b/drivers/crypto/hifn_795x.c
> @@ -2579,6 +2579,7 @@ static int hifn_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>         for (i = 0; i < 3; ++i)
>                 if (dev->bar[i])
>                         iounmap(dev->bar[i]);
> +       kfree(dev);
>
>  err_out_free_regions:
>         pci_release_regions(pdev);
> --
> 2.14.1
>

Nice catch.

Reviewed-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>

Regards,
PrasannaKumar

From 1584465990457641371@xxx Sun Nov 19 04:08:40 +0000 2017
X-GM-THRID: 1584465990457641371
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread