Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Aleksey Makarov <aleksey.makarov@auriga.com>
To:     <netdev@vger.kernel.org>
CC:     <linux-kernel@vger.kernel.org>,
        "Goutham, Sunil" <Sunil.Goutham@cavium.com>,
        Robert Richter <rric@kernel.org>,
        "Florian Westphal" <fw@strlen.de>,
        Eric Dumazet <eric.dumazet@gmail.com>,
        "Aleksey Makarov" <aleksey.makarov@cavium.com>,
        Sunil Goutham <sgoutham@cavium.com>,
        Aleksey Makarov <aleksey.makarov@auriga.com>,
        <linux-arm-kernel@lists.infradead.org>
Subject: [PATCH net v3] net: thunderx: Fix TCP/UDP checksum offload for IPv6 pkts
Date:   Thu, 23 Nov 2017 22:34:31 +0300
Message-ID: <20171123193432.6925-1-aleksey.makarov@auriga.com>
In-Reply-To: <20171123193014.6632-1-aleksey.makarov@auriga.com>
References: <20171123193014.6632-1-aleksey.makarov@auriga.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Sunil Goutham <sgoutham@cavium.com>

Don't offload IP header checksum to NIC.

This fixes a previous patch which enabled checksum offloading
for both IPv4 and IPv6 packets.  So L3 checksum offload was
getting enabled for IPv6 pkts.  And HW is dropping these pkts
as it assumes the pkt is IPv4 when IP csum offload is set
in the SQ descriptor.

Fixes:  3a9024f52c2e ("net: thunderx: Enable TSO and checksum offloads for ipv6")
Signed-off-by: Sunil Goutham <sgoutham@cavium.com>
Signed-off-by: Aleksey Makarov <aleksey.makarov@auriga.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
---
 drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 1 -
 1 file changed, 1 deletion(-)

v3:
- fix the Fixes: tag (David Miller)
- add Reviewed-by Eric Dumazet

v2: https://lkml.kernel.org/r/20171123144158.26111-1-aleksey.makarov@auriga.com
- don't enable checksum offloading both for IPv4 and IPv6 (Eric Dumazet)

v1: https://lkml.kernel.org/r/20171122123727.23580-1-aleksey.makarov@auriga.com


diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c b/drivers/net/ethernet/cavium/thunder/nicvf_queues.c
index d4496e9afcdf..8b2c31e2a2b0 100644
--- a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c
+++ b/drivers/net/ethernet/cavium/thunder/nicvf_queues.c
@@ -1355,7 +1355,6 @@ nicvf_sq_add_hdr_subdesc(struct nicvf *nic, struct snd_queue *sq, int qentry,
 
 	/* Offload checksum calculation to HW */
 	if (skb->ip_summed == CHECKSUM_PARTIAL) {
-		hdr->csum_l3 = 1; /* Enable IP csum calculation */
 		hdr->l3_offset = skb_network_offset(skb);
 		hdr->l4_offset = skb_transport_offset(skb);
 
-- 
2.15.0


From 1584886432283468307@xxx Thu Nov 23 19:31:24 +0000 2017
X-GM-THRID: 1584886432283468307
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread