Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762841AbYALBE1 (ORCPT ); Fri, 11 Jan 2008 20:04:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932071AbYALBES (ORCPT ); Fri, 11 Jan 2008 20:04:18 -0500 Received: from rv-out-0910.google.com ([209.85.198.189]:57292 "EHLO rv-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761552AbYALBES (ORCPT ); Fri, 11 Jan 2008 20:04:18 -0500 Message-ID: <29ab51dc0801111704i3accfa05v24cece3cdbdf992b@mail.gmail.com> Date: Sat, 12 Jan 2008 10:04:11 +0900 From: "Nobuhiro Iwamatsu" To: "Andrew Morton" Subject: Re: [PATCH] pcmcia: Add support P2CCLK bit enabler for TI PC1520 Cc: linux-pcmcia@lists.infradead.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20071225140419.9d2d80db.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20071218185724.a9ba0cae.iwamatsu@nigauri.org> <20071225140419.9d2d80db.akpm@linux-foundation.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2201 Lines: 55 2007/12/26, Andrew Morton : > On Tue, 18 Dec 2007 18:57:24 +0900 Nobuhiro Iwamatsu wrote: > > > There is a device that doesn't work when P2CCLK's bit of TI PC1520 was disable. > > This patch supports P2CCLK bit enabler for TI PC1520. > > > > ... > > > > config YENTA_TOSHIBA > > default y > > bool "Special initialization for Toshiba ToPIC bridges" if EMBEDDED > > diff --git a/drivers/pcmcia/ti113x.h b/drivers/pcmcia/ti113x.h > > index d29657b..ea749e8 100644 > > --- a/drivers/pcmcia/ti113x.h > > +++ b/drivers/pcmcia/ti113x.h > > @@ -59,6 +59,7 @@ > > #define TI122X_SCR_SER_STEP 0xc0000000 > > #define TI122X_SCR_INTRTIE 0x20000000 > > #define TIXX21_SCR_TIEALL 0x10000000 > > +#define TI122X_SCR_P2CCLK 0x08000000 > > #define TI122X_SCR_CBRSVD 0x00400000 > > #define TI122X_SCR_MRBURSTDN 0x00008000 > > #define TI122X_SCR_MRBURSTUP 0x00004000 > > @@ -822,6 +823,13 @@ static int ti12xx_override(struct yenta_socket *socket) > > printk(KERN_INFO "Yenta: Enabling burst memory read transactions\n"); > > val |= TI122X_SCR_MRBURSTUP; > > } > > + > > +#ifdef CONFIG_YENTA_TI_P2CCLK > > + if ( !(val & TI122X_SCR_P2CCLK)) { > > + printk(KERN_INFO "Yenta: Clock generated by internal oscillator\n"); > > + val |= TI122X_SCR_P2CCLK; > > + } > > +#endif > > if (val_orig != val) > > config_writel(socket, TI113X_SYSTEM_CONTROL, val); > > It would be much better if we cold do this without the config option: just > detect the appropriate device and make it work. This bit is enable for PC in BIOS. However, I think that I want to control even by the kernel in building in because it is a boot loader situation. I think that this will not be able to be done by automatic. Please apply this patch. regards, Nobuhiro -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/