Received: by 10.223.164.202 with SMTP id h10csp1758345wrb; Fri, 24 Nov 2017 00:44:50 -0800 (PST) X-Google-Smtp-Source: AGs4zMaD/R6h6VpbPg2zdo4QfaTJViri6+FWoNhuBmWVjW8sZsesVdhM9cMwDAQ6xM7PeXqkRdEZ X-Received: by 10.159.246.7 with SMTP id b7mr3881670pls.81.1511513090804; Fri, 24 Nov 2017 00:44:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511513090; cv=none; d=google.com; s=arc-20160816; b=A+iyHSLguf8LPfqu4rtf7XBGwZcxl3vbWo/pnStOaH3fxioQgfR4we5HkOCgB6nkRA 78vKCDx21qu4NHvmyyeo/TdZzReRrfcQBEsjm6bkFwmAfo2L+eUfOzhTNnOvDUHwd2i2 iZ+MX7rjJWHqs3Rp0uCY+psQn+qyZRwxHUFSzb8cud/bhcp5wpKaSpWawOilv9k9rRgW d8ib+2nGwo4rFIqk8vVswnrN4VGPRf1JqRUcQT3lRLtCPJCI03bU9sV3QNY3PIoj7bUH TCITBc/neFp9ZVeT95OSfyztmTSOh8AgmOq5uzi6hGxT65urIPZvxT17dMXQ0S/hzNk9 gLfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:spamdiagnosticmetadata :spamdiagnosticoutput:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature:arc-authentication-results; bh=GGZLfyGG7gzxXyFiIfP9GfOTV3dYPZCoknj/JbBAlWc=; b=V/Snm10zBAMeBVQMe4lle2/i31mKUH9G658Dz/St70edetBbhKt5tL2L4ZMoWqFD+5 XNn+MpaH1W2gHmrtr7D00sOIzWP256kSM9MuO3FeeRFKGYanPot9zOqA6zrmiJfd3jDx XQmnwXwzGpTjkIVyubdtl4VWR3ux3ZUaOizOKracjtu2d7XE0T1/+mcmIUk3D7Q7nCfb tOT2NnFsBZ7Ns5HpPfkq8L07yJp9wL0OmeAhpdFP5AUADlqXu/4k+VjrUlFl6YmrQTu4 zgocUw3WmoxkJs0ehd3df+11qkx3iPx7W63qPjcTHxmbhVr/0D0HluK/PDm/Zb7K+Q09 PhRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector1-amd-com header.b=yX9x31TM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d15si15612506pli.594.2017.11.24.00.44.39; Fri, 24 Nov 2017 00:44:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector1-amd-com header.b=yX9x31TM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752438AbdKXIoB (ORCPT + 76 others); Fri, 24 Nov 2017 03:44:01 -0500 Received: from mail-co1nam03on0055.outbound.protection.outlook.com ([104.47.40.55]:16064 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752057AbdKXIn7 (ORCPT ); Fri, 24 Nov 2017 03:43:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=GGZLfyGG7gzxXyFiIfP9GfOTV3dYPZCoknj/JbBAlWc=; b=yX9x31TMEunIf15epT2rRpTHm8/EEplwnGP/IhcLAD8wLFdsj5udJJqTP7nAcKkAule61MqGPVh6zcJBrC3M8jdFBw5lRa2QpLkDa3aDZt3qAbjx1sav78h3s5vNIIhqEh8ezbi8ttMq1zEQptULZq+jxIAzxVjvJIXd+fwYJLQ= Received: from [10.129.12.246] (125.21.194.1) by DM5PR12MB1674.namprd12.prod.outlook.com (10.172.40.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.239.5; Fri, 24 Nov 2017 08:43:50 +0000 Subject: Re: [PATCH] ASoC: amd: added error checks in dma driver To: Guenter Roeck Cc: Mark Brown , alsa-devel@alsa-project.org, Takashi Iwai , Liam Girdwood , perex@perex.cz, Alex Deucher , Akshu.Agrawal@amd.com, Guenter Roeck , linux-kernel , Dominik Behr , Daniel Kurtz , Guenter Roeck References: <1511454602-7259-1-git-send-email-Vijendar.Mukunda@amd.com> <20171123172904.4akrfhlonlwkmgs6@sirena.org.uk> <5ec79579-c6c6-6a74-5eca-fecf87defb59@amd.com> From: "Mukunda,Vijendar" Message-ID: Date: Fri, 24 Nov 2017 19:49:00 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [125.21.194.1] X-ClientProxiedBy: PN1PR0101CA0042.INDPRD01.PROD.OUTLOOK.COM (10.174.150.28) To DM5PR12MB1674.namprd12.prod.outlook.com (10.172.40.143) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603199);SRVR:DM5PR12MB1674; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1674;3:ZAO5MbuMzDJkWvRZQm9cFO9A9fHC1TLQOs164B0W8eUPIjnDicHY58kyAMwHjqzYuTDLbF/Alu3fwpwB+FZsqXh8KdFH0edP3dULcpvlk41LeTAEsVnCMSHvMYTlSBP9Qs5X9tMPozXfoajcOF9gMHif2z28CRCgCaxEcyp/+P+u9+8/BinVoXB8m8/gPkT+Rlg2TfDYD6kppHNphQyMb87a31TVXoSp+0fuZgX932JsDudIGKReA+xlNVVTI+mz;25:Lr5v7AVuOgiSPzIC3cikWiRYqgpC+Gj3RcubZFuR2ZmOusC+9w8xKW1XfMPfse9F6nwn8hhjIXlkbNOneOMmEnyUQB+WG0ZLiNNNKd8OAyqYwkqw8d0sf6r5NaUQToXXR4/dxuigV4QFWTD88x8suyhszlUVRnv+Gs/LwibAcgqJ2Wb2/dNZy4RCFnpceLtvvneG4+PVxkKe1SWsuITQQJwtZ5UuHlwJVRHna/hUR52+e6JGKamXz+v4IUKPLaFVlOUIJwRquhcOAj4E2Ieb9goywgtKvNaLRTeqCm07dDu8QV+qsYqSHUY9gCV9iwt9GHl2NSAtF00QfkMdAQogkQ==;31:likbH6KtZn/+HzyU06CNThN39uzAGYUYSE2rX2mpTdJL69O6ojygORMjFqOzf18sytJQzyRqiCulip5OqnE8LmV0Zf1jSjoTDFWeZShfE/mgDx1nuOg5hiZapTna7FdvTFzZpnuYr/15blItL3ZNIY5AKVp9euE2FrXxAp7c9bP2TeJyCH4TU6J62ir+XyImirCf5ySY7FMX6iosrTAfOVMOFwU0netPyon9N+PxJtQ= X-MS-TrafficTypeDiagnostic: DM5PR12MB1674: X-MS-Office365-Filtering-Correlation-Id: 75501be2-2bf9-4cb6-294b-08d533178025 X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1674;20:P7rmurR13pifx1v5RAe/yKasttype9FM9Avw4Lsg2ZtH5VpWgyNr5EJhZ8MygoCugmgr3GpR5mOlwUzCgVaKKjFKbmXYHn7ndGlkthNponHqQUCfz/KOvLMgi1lo3WuHcazlk3+wT4mq/ksfc7W6JBqRSk+ePYZ0+9DWjLD1pk2YcHB+DSRBcNil53MaCYFOVRYxxV4aAFFt8f16i7SemK2L3HBcYnklt5ZvB3c1xFY8NOR2fDvMwUf78jJIt9IS5EllYQXBMtU/exlpMiYBegVQnidenlZdoVzx6PX9i62q9K47D+MT9l4aI85ag6iHCcJHK6tEh/+Dz/0nxz4V21I/7IepSe6PwBrri6pYndC+XWyEFVgluhIjHZP6ulA61GrQOLuQDqwBcAdq0DBG9eYy44I/Li9uNwFDhR36lHOjsRh9UpyXPzsOomNeE9f8ob3wraom5FCMv/7POMqTUuCcpEZl4qrDWGdvb3OmexdFacRqy6NnzAwYhhYvmtmO;4:KxR7b/zmDq6M27t36H7T6lCsFwMxK0Hx/PifPBnFe0ancx+trAFLnw/n02FseNxWM5qFPNc9DmLG7gzx+eSKILTppaBhMm7ugPFZE2a18vKUGdOk/FCeimXOhnMmPeVC4AeYkdMuHtYIDt3ml/5R2mHHiOsXoeoDj24FjBSxWDWCLXNMJmq3prVN6cZwHJlN41FwzgvEHeL9lOOxYbPAdJBL2KD3VCcauVdiH90PDE6DVOjSuR9PZ0axDuefnJx1IOf1mfuObtiMPzD3Cgj7y7UcEUB7Ju3nfufHNWbvNPqV4VP0N+Tkk65+nWSkOdGI X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(3231022)(93006095)(93001095)(6055026)(6041248)(20161123560025)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123558100)(6072148)(201708071742011);SRVR:DM5PR12MB1674;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:DM5PR12MB1674; X-Forefront-PRVS: 05015EB482 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(376002)(366004)(346002)(39860400002)(189002)(199003)(24454002)(72206003)(16576012)(6486002)(65806001)(83506002)(47776003)(7416002)(4326008)(53936002)(86362001)(230700001)(31696002)(65956001)(93886005)(52146003)(6246003)(81166006)(53546010)(8676002)(77096006)(39060400002)(3846002)(90366009)(23676004)(7736002)(66066001)(105586002)(8936002)(229853002)(50466002)(6116002)(5660300001)(2906002)(36756003)(6666003)(68736007)(81156014)(97736004)(106356001)(65826007)(25786009)(33646002)(50986999)(6916009)(189998001)(76176999)(2950100002)(316002)(101416001)(58126008)(64126003)(31686004)(54906003)(67846002)(478600001)(52116002)(2486003)(54356999)(305945005)(16526018);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1674;H:[10.129.12.246];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Vijendar.Mukunda@amd.com; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjEyTUIxNjc0OzIzOjRrRm5ucTZ4N0xUblVidDFsM1BkemY5c1ZY?= =?utf-8?B?UXU3NlNTcVhrRCsrNFQ3OHprdVducnZsTHhLL3RyUkY5elB5RmxlTTJ2cFZ2?= =?utf-8?B?UENXUUJvQndDSEMyWDNmN3B5SEx3UTFpSno2VHpVQWw2VjhYNldidGRTbE40?= =?utf-8?B?V2lMdVRZK3RiWU9rWEFSUGoyQ2dCdVlQTzc4MzlkZkZtYW5jSnIxSzh0Z0Vq?= =?utf-8?B?bHJNWm0vVExLeHhLRWE1RDZYR3BHelJJWWkwTHpSS0F5ZW9XdXppeXA1NlU4?= =?utf-8?B?aGU3M1BnUkhlbTJGN3kvY3gxV29scjNySGZFaHNMdVo1aGh3MjYzOVcrT1VE?= =?utf-8?B?eHMwNmd6VitZaWVZb29QVU9nWGlrTU9vajJVTWtPUnprdEcyWGx6L0VuOGQ2?= =?utf-8?B?YU1OOE1Zak5UditjUHVYa2pTUHFST3ZRNnZKMnRES1cyTjJCWVBwWlcySWtW?= =?utf-8?B?Ri8xNWZQcnFCbi9QaW4rZzJQSGh2ZnJWanRsZGhEUUo3TXJDNnJBMDZ1K0Ra?= =?utf-8?B?dnFKVVE0MFZQOXVucENrY3NoSm1WMWl2TUVKL1ZMbEQ2ZC9wTWpMaWl2d3lu?= =?utf-8?B?Um9MbUJLNVVwSUIyNFZ6bnpPRFdXaGxXQTdFc0IvYzlXYWF6bUdVcHBNUFJ1?= =?utf-8?B?UFF1M05BZitSdzRlbDM2ZHVNS1IwU1JoL0Qxc0VLSDVka3NMMTVMWlFVSFYr?= =?utf-8?B?T1pEb21CUVhja3BrQlIyKzhoaEsxTEVsVVRta28rN01mRklPY3JROUYxY3Zo?= =?utf-8?B?VW9RMzc4TG9mQ25sWlBHK3pjTlpZWGl3NTA3T2VERG1lUmtnL1RFUHNWYXFO?= =?utf-8?B?S1ZvcCswdENYc1pGR0thZDhhU2FMeVRXaHFKS1BqOWhodmt0aDdZdDE4TEtv?= =?utf-8?B?cU9Dc2piM1hGZVFNaThVQXFBSmgzV0hCNHlMbDlZaDUwWWtId2E2RU1vL21w?= =?utf-8?B?dk5rRThUaGptVVRTWGxSZE01cXVYak9nSjVWVXJhNFpYVEFlREozdFpiTWE0?= =?utf-8?B?b2xFZmhob2pHV1MwNlBCRzhUbmhJK1ZKMm5rcUxpek5JNzA3VjFmRmNGSlp1?= =?utf-8?B?ODZaeEY4N1ROZm85RDQ4aGJUM3V6bzJYYVFhZWFDaGd2OTdvQVJsMlM1RkFu?= =?utf-8?B?QkxwM0FkTHRuVU91UWNMSldjRkhlS1dqTGNHQUVkaysyRmxUT2NqWGtkdHFm?= =?utf-8?B?alM3L05qdFN6Zm9jSTlzMXpZM29JcFVUVjdTN0h4ZXM1Z2xtY1gwZDVhMCt4?= =?utf-8?B?YjdNWmhRVmFZWlAyNzVoaFowWUg1M2FNUEpXMzhzVENJejd5a0NrdzJ3VW9U?= =?utf-8?B?UTNIRllUaGpVbzFFZGU1QVJ3RG5EQlBrQ1pQOFRyQjVHQ0szcjBjbjVHQ09X?= =?utf-8?B?ZHh1d0RZVkJSZGtUK21QeENHcCswU3VUdERtMDJxMzNkdkRLQW0rc0p6MStO?= =?utf-8?B?MEdxYnJQa25oYUU1RWNFYUNLTHI4Q3lraUVMMTZlb2dYSnY2Rmx1SXljbkZI?= =?utf-8?B?VGZqa2pLRXp0b2VlV0hEZkt6Q3N2NzV1dVQ3QnVBR1pVQ01yUzVtNEViWjdY?= =?utf-8?B?OFpZYVVGZWt0OStERjBOOW9vVWh2Tmt5emFBbnQwUHVuczhZbUZJazNSa0Rm?= =?utf-8?B?K3Ara0VsZkVnQm5iMGJVc3ZPNnRUNHlPRFViVHhQS1VEbzN3SXgydGdpVmM1?= =?utf-8?B?RTYvVkEzTGwxN0U2M0wvcGxQQTkwektkTUlsMW5TeWZZeTRZaGNMaDllQW5K?= =?utf-8?B?RHRBbXJod3NBWERLcjFGVWZEcXNsUnhNQWZJLzkwVE96SWpoemw1NFlIbi9Y?= =?utf-8?B?ck5YOEk1Ui8xc1pieXU1MmNESU12YVloNmNET051Tm9pUDZseDY0dHZQWU9h?= =?utf-8?B?UHFrelp1dDhxb2k5WjJvYWF5ZFlUWnNwQWI0OUZsTU1kRVpPUjFhdEZLazNJ?= =?utf-8?B?dy9idXdXS21wMWczYXlYU2RpK24zQWF3SlJ3QnAyNi91aWRsOThOUTdPaUVN?= =?utf-8?B?R05rRXVjaFZEL2pFYWtCVENlQTE1OHhjcW5sMDVBbUxjYURhdVhLVGFrWXZG?= =?utf-8?B?elJRTjRWdW1nSW01eC9aUzE3SjB1YkFabzRKMGgwRm4rcFJzdW5qQnhoZlV4?= =?utf-8?Q?AnLgS3cTzfbaQFdbVFH05AI=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1674;6:ldbEZAvYAaoYW1cDcSuxlUOBe81vGqaBBSdtY1GpCQHWwrFqzXPc14O+U2/MhwBiVl51fgFe1ebo/FduTEuZMJGewmjDdVjC1A2j36OQ/1thyNkIgUd5M2/mRfjac+4IvdpwL/3+VH3/wwhEwvvxAy5LSZwi3C+RHvmi1j7/jnUu5siHBIHY+8T+gE8t/8I3xDQfzAy3YGy8xlBczTePGKQ0vtTthWo9j2RSfMEvlRbapzahURjUjh25PqdLbKRPjqFasdPuIZBqIS5yGR2vzm/cHKHeNAXzYZ5PfzWJEKWHB1o8t4LI+8R2yG1J+3ZiVI+O7YHW/4Dl4vvlbV95Wmqgao6+UelsDtT3Hvw2n5w=;5:Crtv6DRS6huwQQbW7WWp+Xbi92xSj1LG31KeqnaGtBz7uV7vdLTDN5/ovFJ23FvZbPAvUE1mB2ZhEE+hJWRZdKmSSnoLFjWYtbQ00oDQbivGr4T6oUn3oRk1vAtqrWXwSP7b15Lcze00TvErfkc5Uh3NmYa9nTJ+OvZ0FUNvizQ=;24:mu4KvzkLTlYPKFJnEIt1STh/3qsR5xj1t146UiYC2vwt6CsJRAB/7VDk9MIzXqLFM189ab3uxTJW8qb1lPNwKuFvnSyG18XBJDo2NRvG22w=;7:UelUFgnHPD/kt+quioIKluvur+TnQLprGErLSMUWeUfnWFJhDSGhcUHRErkK8XWOBRlmxFNDGz9W1nsh0AWtycS8sJr9FJ5yGzsvNGqFnbH7A/VUuRnwmS/9Z9zEvMxm15EBM2YNtQ2UhpNbdBno7hECIRPviliT/MU/t2QevctWeyKczqHSUQ8flPB6Q696L/yrptOncyFaauaZW9lkag4CsngG2PEutyONlAm+iPIk/EXote/2fhIo+4TseLxl SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1674;20:JUcFg1u2b31p9CvGFGxkUKmNOcSIylN3tb1ohd0IE8n74ieXLtWg6Z/tDl3Lh4uJ046Yqx+XL0T2tvbBa1sue7oF3hAaQi8F4vWK5/LS9epdRSLTdTl0rtW43gmk/KICs0WAnAUeLcJUjdBqbT8Ch7ABjY9zPW5mCG1U8YTbr9VSrI543OYE13Ppz2r7Tptcju/7brDCiv3IN6kzY7gIBhxlSUWWJnd9FYvA1atrQI/c59p019W4KuIyiVWdocm5 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2017 08:43:50.5288 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 75501be2-2bf9-4cb6-294b-08d533178025 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1674 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 24 November 2017 01:41 PM, Guenter Roeck wrote: > On Fri, Nov 24, 2017 at 3:07 AM, Mukunda,Vijendar > wrote: >> >> >> On Thursday 23 November 2017 10:59 PM, Mark Brown wrote: >>> On Thu, Nov 23, 2017 at 08:59:43AM -0800, Guenter Roeck wrote: >>>> On Thu, Nov 23, 2017 at 8:30 AM, Vijendar Mukunda >>>> wrote: >>>>> added error checks in acp dma driver >>>>> Signed-off-by: Vijendar Mukunda >>>>> Signed-off-by: Akshu Agrawal >>>>> Signed-off-by: Guenter Roeck >>>> This is inappropriate. >>> Specifically: if Guenter wasn't involved in writing or forwarding the >>> patch he shouldn't have a signoff in there, and if you're the one >>> sending the mail you should be the last person in the chain of signoffs. >>> Please see SubmittingPatches for details of what a signoff means and why >>> they're important. >> >> This patch was implemented on top of changes implemented by Guenter. >> There is a separate thread - RE: [PATCH] ASoC: amd: Add error checking >> to probe function in which Guenter posted changes. > That was my patch. This is yours. > > Guenter Got it , Let your patch go as it is. Will submit a fresh patch for additional error checks in acp dma driver. > >> Got it, apologies will post changes as v2 version. >> From 1584934324703374518@xxx Fri Nov 24 08:12:38 +0000 2017 X-GM-THRID: 1584853998505310579 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread