Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <5ec79579-c6c6-6a74-5eca-fecf87defb59@amd.com>
References: <1511454602-7259-1-git-send-email-Vijendar.Mukunda@amd.com>
 <CABXOdTezJbmEU=Oa+G1NN+WHoZqJERH8DAapJqgbPXkLnyweLw@mail.gmail.com>
 <20171123172904.4akrfhlonlwkmgs6@sirena.org.uk> <5ec79579-c6c6-6a74-5eca-fecf87defb59@amd.com>
From:   Guenter Roeck <groeck@google.com>
Date:   Fri, 24 Nov 2017 00:11:47 -0800
Message-ID: <CABXOdTeR9P3mAithS++cZaGkWRjgjPrPfT4dGDojyT5VSUsNRA@mail.gmail.com>
Subject: Re: [PATCH] ASoC: amd: added error checks in dma driver
To:     "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
Cc:     Mark Brown <broonie@kernel.org>, alsa-devel@alsa-project.org,
        Takashi Iwai <tiwai@suse.de>,
        Liam Girdwood <lgirdwood@gmail.com>, perex@perex.cz,
        Alex Deucher <Alexander.Deucher@amd.com>,
        Akshu.Agrawal@amd.com, Guenter Roeck <linux@roeck-us.net>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Dominik Behr <dbehr@chromium.org>,
        Daniel Kurtz <djkurtz@chromium.org>,
        Guenter Roeck <groeck@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Nov 24, 2017 at 3:07 AM, Mukunda,Vijendar
<vijendar.mukunda@amd.com> wrote:
>
>
>
> On Thursday 23 November 2017 10:59 PM, Mark Brown wrote:
>>
>> On Thu, Nov 23, 2017 at 08:59:43AM -0800, Guenter Roeck wrote:
>>>
>>> On Thu, Nov 23, 2017 at 8:30 AM, Vijendar Mukunda
>>> <Vijendar.Mukunda@amd.com> wrote:
>>>>
>>>> added error checks in acp dma driver
>>>> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
>>>> Signed-off-by: Akshu Agrawal <Akshu.Agrawal@amd.com>
>>>> Signed-off-by: Guenter Roeck <groeck@chromium.org>
>>>
>>> This is inappropriate.
>>
>> Specifically: if Guenter wasn't involved in writing or forwarding the
>> patch he shouldn't have a signoff in there, and if you're the one
>> sending the mail you should be the last person in the chain of signoffs.
>> Please see SubmittingPatches for details of what a signoff means and why
>> they're important.
>
>
>   This patch was implemented on top of changes implemented by Guenter.
>   There is a separate thread - RE: [PATCH] ASoC: amd: Add error checking
>   to probe function in which Guenter posted changes.

That was my patch. This is yours.

Guenter

>       Got it, apologies will post changes as v2 version.
>

From 1584924389702036975@xxx Fri Nov 24 05:34:43 +0000 2017
X-GM-THRID: 1584853998505310579
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread