Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 23 Nov 2017 17:29:04 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Guenter Roeck <groeck@google.com>
Cc:     Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
        alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
        Liam Girdwood <lgirdwood@gmail.com>, perex@perex.cz,
        Alex Deucher <Alexander.Deucher@amd.com>,
        Akshu.Agrawal@amd.com, Guenter Roeck <linux@roeck-us.net>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Dominik Behr <dbehr@chromium.org>,
        Daniel Kurtz <djkurtz@chromium.org>,
        Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH] ASoC: amd: added error checks in dma driver
Message-ID: <20171123172904.4akrfhlonlwkmgs6@sirena.org.uk>
References: <1511454602-7259-1-git-send-email-Vijendar.Mukunda@amd.com>
 <CABXOdTezJbmEU=Oa+G1NN+WHoZqJERH8DAapJqgbPXkLnyweLw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="6mh7mhhjq6beh7ux"
Content-Disposition: inline
In-Reply-To: <CABXOdTezJbmEU=Oa+G1NN+WHoZqJERH8DAapJqgbPXkLnyweLw@mail.gmail.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--6mh7mhhjq6beh7ux
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Nov 23, 2017 at 08:59:43AM -0800, Guenter Roeck wrote:
> On Thu, Nov 23, 2017 at 8:30 AM, Vijendar Mukunda
> <Vijendar.Mukunda@amd.com> wrote:
> > added error checks in acp dma driver

> > Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> > Signed-off-by: Akshu Agrawal <Akshu.Agrawal@amd.com>
> > Signed-off-by: Guenter Roeck <groeck@chromium.org>

> This is inappropriate.

Specifically: if Guenter wasn't involved in writing or forwarding the
patch he shouldn't have a signoff in there, and if you're the one
sending the mail you should be the last person in the chain of signoffs.
Please see SubmittingPatches for details of what a signoff means and why
they're important.

--6mh7mhhjq6beh7ux
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAloXBV8ACgkQJNaLcl1U
h9CM0gf7BWFncOvkptqVZ9NazytgwxSNx8atH26B5BEmiMrTgUZQmvA4RoaDIj/S
yCo5UtvNE5gpWGkTFAILJmz4ZtAyNoYhsIjJX4GcjdTbwOVfpsaLwZ5nD/c5YeB8
dhAr84/zumBcuo/ZBuakvesRhU9ClvREOh6VCYCV1NvkoV0Hz76RkIwXYukftA2z
+IBGMqANNSN6OjuAVVZ7wcpsrC0KzGCMbuK8G5vLRB/BLp1Ydg0BgbGTRDUHH+LF
hR9LedTEis+TXz9FvGfc4oDuyIn6JIp0J4w8ZgVx/PO9T4+4anduiA8C2X3BkZw3
9rb+22kelEprL58QlqLhQ9oesKXjAQ==
=ELKM
-----END PGP SIGNATURE-----

--6mh7mhhjq6beh7ux--

From 1584876943303446523@xxx Thu Nov 23 17:00:35 +0000 2017
X-GM-THRID: 1584853998505310579
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread