Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 27 Nov 2017 14:05:25 +0100 (CET)
From:   Sebastian Ott <sebott@linux.vnet.ibm.com>
To:     Will Deacon <will.deacon@arm.com>
cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        Martin Schwidefsky <schwidefsky@de.ibm.com>,
        Heiko Carstens <heiko.carstens@de.ibm.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [bisected] system hang after boot
In-Reply-To: <20171127124506.GB30679@arm.com>
References: <alpine.LFD.2.21.1711221832100.1728@schleppi> <20171122182659.GA22648@arm.com> <20171122202217.GO3326@worktop> <20171127114947.GA30679@arm.com> <20171127124506.GB30679@arm.com>
User-Agent: Alpine 2.21 (LFD 202 2017-01-01)
Organization: =?ISO-8859-15?Q?=22IBM_Deutschland_Research_&_Development_GmbH?=
 =?ISO-8859-15?Q?_=2F_Vorsitzende_des_Aufsichtsrats=3A_Martina?=
 =?ISO-8859-15?Q?_Koederitz_Gesch=E4ftsf=FChrung=3A_Dirk_Wittkopp?=
 =?ISO-8859-15?Q?_Sitz_der_Gesellschaft=3A_B=F6blingen_=2F_Reg?=
 =?ISO-8859-15?Q?istergericht=3A_Amtsgericht_Stuttgart=2C_HRB_2432?=
 =?ISO-8859-15?Q?94=22?=
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Message-Id: <alpine.LFD.2.21.1711271403550.1783@schleppi>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 27 Nov 2017, Will Deacon wrote:
> Sebastian: could you try the diff below, please? If that fixes s390, then
> we can debate the merits of GENERIC_LOCKBREAK independently of fixing this
> issue.
> 
> Thanks,
> 
> Will
> 
> --->8
> 
> diff --git a/kernel/locking/spinlock.c b/kernel/locking/spinlock.c
> index 1fd1a7543cdd..0ebb253e2199 100644
> --- a/kernel/locking/spinlock.c
> +++ b/kernel/locking/spinlock.c
> @@ -68,8 +68,8 @@ void __lockfunc __raw_##op##_lock(locktype##_t *lock)			\
>  									\
>  		if (!(lock)->break_lock)				\
>  			(lock)->break_lock = 1;				\
> -		while ((lock)->break_lock)				\
> -			arch_##op##_relax(&lock->raw_lock);		\
> +									\
> +		arch_##op##_relax(&lock->raw_lock);			\
>  	}								\
>  	(lock)->break_lock = 0;						\
>  }									\
> @@ -88,8 +88,8 @@ unsigned long __lockfunc __raw_##op##_lock_irqsave(locktype##_t *lock)	\
>  									\
>  		if (!(lock)->break_lock)				\
>  			(lock)->break_lock = 1;				\
> -		while ((lock)->break_lock)				\
> -			arch_##op##_relax(&lock->raw_lock);		\
> +									\
> +		arch_##op##_relax(&lock->raw_lock);			\
>  	}								\
>  	(lock)->break_lock = 0;						\
>  	return flags;							\

I tested that on top of 4.15.0-rc1 and it worked!

Sebastian


From 1585224432702626977@xxx Mon Nov 27 13:03:47 +0000 2017
X-GM-THRID: 1584789385193417838
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread