Received: by 10.223.164.202 with SMTP id h10csp643487wrb; Wed, 22 Nov 2017 12:56:55 -0800 (PST) X-Google-Smtp-Source: AGs4zMb/uEiERENftEWL6OjFfioGn8s/xOWkF/L/JBWRoOQ3szwuIObwl0ETj+9oOqc5zsGRN5oh X-Received: by 10.84.210.164 with SMTP id a33mr23110931pli.134.1511384215683; Wed, 22 Nov 2017 12:56:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511384215; cv=none; d=google.com; s=arc-20160816; b=iEo7cLQVtdbfg1KFAB+nz5p1Jtq1ejeYFddTm8VlQCTEGNBq4zl+flxopyjDSWDRVL rXDKIcSA92OXOBUSBRgb1LoYLce/iKBgLx9APs6iJVscPmqCm6doysAabySXlVchNymJ C6sirKc74lxWgkixl8gSN+ZP6+KmsxQRQvWFQvmGpDGRpEOKoy4HYsEbxLW/r3NzGG+h ytUD7BwU5/LLwhtgVXHveFnShKnRvL5BjcAtdSaD/RcpMMk31XrEmd6VFzY9L/nqddlf g1aYINARjPSfApBTZKMk7FScZH7/w4OD9po6PwoP43W/qOODF/WMr27FgB3EiD3tNtC+ BBhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :mime-version:dkim-signature:arc-authentication-results; bh=m17HEDStRRtQmeFHmDvTjtXmz5jWM4ZfVM0+0ALI9IA=; b=AJdsjAD6B2I4vSYRTbrE0JcdzhW0he37KWEmveDkmxKaJX0pWkfUShSZnhA16+AiCb A/SehBcPKTkSvjU2Uc2aiRJRZHKYW1MLdGKPZvCqPbIFyVOcR2iLsqUSfhTFOmGjml3x jtVuYIXwZ+vtY8GMQNrH98tOtraC+xb2DGZHxA4uWUmk3DYfOZLok/4tKpoVWSbWcji+ duNEXMiHKDpV/T0eZ7/PqTiDa8ASLo4HpxEzG3JUU1yX5NybVWZwKG5HmtG2SNjIherw gxYKicjxtpGxCQMew528KpoVapvs2Kk2h5RjwCoYA/3SUjUk9p9ZCoHwjHaBg59G/bhp mwbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=BEsNt+TQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 64si14341664plk.227.2017.11.22.12.56.44; Wed, 22 Nov 2017 12:56:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=BEsNt+TQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751482AbdKVUyv (ORCPT + 77 others); Wed, 22 Nov 2017 15:54:51 -0500 Received: from mail-ua0-f177.google.com ([209.85.217.177]:33312 "EHLO mail-ua0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751274AbdKVUyu (ORCPT ); Wed, 22 Nov 2017 15:54:50 -0500 Received: by mail-ua0-f177.google.com with SMTP id q18so11506119uaa.0 for ; Wed, 22 Nov 2017 12:54:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=m17HEDStRRtQmeFHmDvTjtXmz5jWM4ZfVM0+0ALI9IA=; b=BEsNt+TQ/AGrf2A/JzfzykdI1Vjg/qITfFD/d8rUxPqm61zQjtmomEPaYr6skr/5ri sfUXjUEbRyMiN3OPg/AgIEH/GKjGNbVWf371NP03nVbxjBn0jv6koPwcNIkI0pkyEAlQ gVEH21Rvi12oOShTyNMTGNg7TEH1Lfc8EuUpHeqbbCqz1anzi2i2Lb1Rh0TlQ6xky83J fdno6I/EKlfUCM/UdSn8zbdXB/uXidli6g12f9LNK7cv4nyu7Ie8AtFggoBDK65WJQPm c+7PmhIxWKNpF3hjJQNvPlGV0UVqWdO/LYByYoDzo2vTor+Soi2dJtJPTM4OKnKNMglQ Uzdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=m17HEDStRRtQmeFHmDvTjtXmz5jWM4ZfVM0+0ALI9IA=; b=OOI9+sS3lryQbkFF5Pz9LVUfu9HiSYDHI6CTnMFfqvEwhc6zvtEpo8aoDtmuZrWPZw lRQuOu2siJciFy7/uD9GQ3HcSfJ9m8R0DW1gmk4MCCvT/XNwLSlxm71lsqGTuh0g+Zqc NQRMCsleQxok6jT82n7ds0BKxJMQ1wL/+qdnAF/uhnhqL/y3/75mJ17n399yeVQ/URF6 A14ChDOvmP/fc5YtN/FdAzbHon03ow3ENUvz7TfCsY6BMwk2pLLg37lYv+IaxpSJhOH7 qKrd6Vjw1IYVL9GB0fQnFO5oP+lc7JnRbO087TWn+HrQlWtdrmhO+PWYIBljSXLW1NM6 aovw== X-Gm-Message-State: AJaThX7wxh4Kb7YlE7+AptaTI5vnsCtrEYGx45nk5Pd8bkqGr/eIB74q tNrh8zQSSyy8/uham1ILHg09VJIUKbsmwCdGUARRhw== X-Received: by 10.159.55.82 with SMTP id a18mr19602450uae.130.1511384089898; Wed, 22 Nov 2017 12:54:49 -0800 (PST) MIME-Version: 1.0 Received: by 10.31.160.146 with HTTP; Wed, 22 Nov 2017 12:54:49 -0800 (PST) From: Kees Cook Date: Wed, 22 Nov 2017 12:54:49 -0800 Message-ID: Subject: i915: enum intel_dpll_id cast To: Rodrigo Vivi Cc: Mika Kahola , intel-gfx@lists.freedesktop.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, While doing Clang test builds, this was reported: drivers/gpu/drm/i915/intel_ddi.c:1481:30: warning: implicit conversion from enumeration type 'enum port' to different enumeration type 'enum intel_dpll_id' [-Wenum-conversion] enum intel_dpll_id pll_id = port; ~~~~~~ ^~~~ Which is from: static void bxt_ddi_clock_get(struct intel_encoder *encoder, struct intel_crtc_state *pipe_config) { struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); enum port port = intel_ddi_get_encoder_port(encoder); enum intel_dpll_id pll_id = port; pipe_config->port_clock = bxt_calc_pll_link(dev_priv, pll_id); ... } In looking at it, it seems to be harmless if as enum port has a smaller range than enum intel_dpll_id. I just wanted to check if maybe something might go weird, since DPLL_ID_LCPLL_2700 maybe ends up getting seen as I915_MAX_PORTS? enum port { PORT_NONE = -1, PORT_A = 0, PORT_B, PORT_C, PORT_D, PORT_E, I915_MAX_PORTS }; enum intel_dpll_id { ... DPLL_ID_LCPLL_2700 = 5, ... }; Thanks! -Kees -- Kees Cook Pixel Security From 1584886338268453018@xxx Thu Nov 23 19:29:55 +0000 2017 X-GM-THRID: 1584886338268453018 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread