Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1511404716.2385.12.camel@perches.com>
Subject: Re: [PATCH 1/4] rk3399_dmc: Fix line continuation format
From:   Joe Perches <joe@perches.com>
To:     Chanwoo Choi <cw00.choi@samsung.com>, myungjoo.ham@samsung.com,
        Kyungmin Park <kyungmin.park@samsung.com>
Cc:     "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date:   Wed, 22 Nov 2017 18:38:36 -0800
In-Reply-To: <5A1633F2.6000103@samsung.com>
References: <1511347280.6989.81.camel@perches.com>
         <cover.1510845910.git.joe@perches.com>
         <7d659960e45f66894126fba9e2d54cf25ae1185b.1510845910.git.joe@perches.com>
         <5A150792.6050104@samsung.com>
         <CGME20171116152742epcas2p22b17887a4d7f2adcd3beb414988dbce3@epcms1p1>
         <20171123012100epcms1p13f78950557de06dbbd65996c8b0645ee@epcms1p1>
         <5A162835.5050806@samsung.com> <1511402826.2385.3.camel@perches.com>
         <5A162E8A.3040207@samsung.com> <1511403518.2385.8.camel@perches.com>
         <5A163119.1050500@samsung.com> <1511404163.2385.11.camel@perches.com>
         <5A1633F2.6000103@samsung.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 2017-11-23 at 11:35 +0900, Chanwoo Choi wrote:
> On 2017년 11월 23일 11:29, Joe Perches wrote:
> > On Thu, 2017-11-23 at 11:23 +0900, Chanwoo Choi wrote:
> > > On 2017년 11월 23일 11:18, Joe Perches wrote:
> > > > never break user-visible strings such as
> > > > printk messages, because that breaks the ability to grep for them
> > > 
> > > So, I suggested "Or, we better to modify the error message within 80 char.".
> > 
> > Run checkpatch on your suggestion.
> > You will get a "split_string" warning.
> 
> I knew about this. I don't like to hurt the readability
> in order to fix the warning with the improper way.
> 
> If you want to fix it, I suggested that you better to modify
> the error message within 80 char. Or I prefer the Myungjoo's opinion.

Again, I don't really care how it's fixed,
but the 3 tabs in the middle of the message
are stupid.

Please fix it.


From 1584822582348868065@xxx Thu Nov 23 02:36:32 +0000 2017
X-GM-THRID: 1584243050242866698
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread