Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Amrani, Ram" <Ram.Amrani@cavium.com>
To:     "alexander.levin@verizon.com" <alexander.levin@verizon.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
CC:     "Elior, Ariel" <Ariel.Elior@cavium.com>,
        Doug Ledford <dledford@redhat.com>
Subject: RE: [PATCH AUTOSEL for 4.9 37/54] RDMA/qedr: Fix RDMA CM loopback
Thread-Topic: [PATCH AUTOSEL for 4.9 37/54] RDMA/qedr: Fix RDMA CM loopback
Thread-Index: AQHTY+CYC84oBVN320aaxeVLs0K1IqMhe++w
Date:   Thu, 23 Nov 2017 06:11:32 +0000
Message-ID: <BN3PR07MB2578AE3AEA8070993CDDAE1CF8210@BN3PR07MB2578.namprd07.prod.outlook.com>
References: <20171122222344.19782-1-alexander.levin@verizon.com>
 <20171122222344.19782-37-alexander.levin@verizon.com>
In-Reply-To: <20171122222344.19782-37-alexander.levin@verizon.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: cavium.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ef5e2317-d8b5-4a2f-7b36-08d532390b59
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2017 06:11:32.5075
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0701MB1344
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Ram Amrani <Ram.Amrani@Cavium.com>
>=20
> [ Upstream commit af2b14b8b8ae21b0047a52c767ac8b44f435a280 ]
>=20
> The loopback logic in RDMA CM packets compares Ethernet addresses and
> was accidently inverse.
>=20
> Signed-off-by: Ram Amrani <Ram.Amrani@cavium.com>
> Signed-off-by: Ariel Elior <Ariel.Elior@cavium.com>
> Signed-off-by: Doug Ledford <dledford@redhat.com>
> Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
> ---
>  drivers/infiniband/hw/qedr/qedr_cm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/infiniband/hw/qedr/qedr_cm.c b/drivers/infiniband/hw=
/qedr/qedr_cm.c
> index 63890ebb72bd..eccf7039aaca 100644
> --- a/drivers/infiniband/hw/qedr/qedr_cm.c
> +++ b/drivers/infiniband/hw/qedr/qedr_cm.c
> @@ -404,9 +404,9 @@ static inline int qedr_gsi_build_packet(struct qedr_d=
ev *dev,
>  	}
>=20
>  	if (ether_addr_equal(udh.eth.smac_h, udh.eth.dmac_h))
> -		packet->tx_dest =3D QED_ROCE_LL2_TX_DEST_NW;
> -	else
>  		packet->tx_dest =3D QED_ROCE_LL2_TX_DEST_LB;
> +	else
> +		packet->tx_dest =3D QED_ROCE_LL2_TX_DEST_NW;
>=20
>  	packet->roce_mode =3D roce_mode;
>  	memcpy(packet->header.vaddr, ud_header_buffer, header_size);
> --
> 2.11.0


Thanks!

Acked-by: Ram Amrani <Ram.Amrani@cavium.com>


From 1584809484313746322@xxx Wed Nov 22 23:08:21 +0000 2017
X-GM-THRID: 1584809484313746322
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread