Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 22 Nov 2017 22:28:48 +0100
From:   Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To:     Matthew Wilcox <willy@infradead.org>
Cc:     linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Matthew Wilcox <mawilcox@microsoft.com>
Subject: Re: [PATCH 05/62] radix tree: Add a missing cast to gfp_t
Message-ID: <20171122212847.axib6ito23sldlbe@ltop.local>
References: <20171122210739.29916-1-willy@infradead.org>
 <20171122210739.29916-6-willy@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171122210739.29916-6-willy@infradead.org>
User-Agent: NeoMutt/20171027
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Nov 22, 2017 at 01:06:42PM -0800, Matthew Wilcox wrote:
> From: Matthew Wilcox <mawilcox@microsoft.com>
> 
> sparse complains about an invalid type assignment.
> 
> Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com>
> ---
>  lib/radix-tree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/radix-tree.c b/lib/radix-tree.c
> index c8d55565fafa..f00303e0b216 100644
> --- a/lib/radix-tree.c
> +++ b/lib/radix-tree.c
> @@ -178,7 +178,7 @@ static inline void root_tag_clear(struct radix_tree_root *root, unsigned tag)
>  
>  static inline void root_tag_clear_all(struct radix_tree_root *root)
>  {
> -	root->gfp_mask &= (1 << ROOT_TAG_SHIFT) - 1;
> +	root->gfp_mask &= (__force gfp_t)((1 << ROOT_TAG_SHIFT) - 1);
>  }
>  
>  static inline int root_tag_get(const struct radix_tree_root *root, unsigned tag)
> -- 

IMO, it would be better to define something for that in radix-tree.h,
like it has been done for ROOT_IS_IDR.

Regards,
-- Luc

From 1584832474353052561@xxx Thu Nov 23 05:13:46 +0000 2017
X-GM-THRID: 1584717880005758635
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread