Received: by 10.223.164.202 with SMTP id h10csp243093wrb; Wed, 22 Nov 2017 20:03:38 -0800 (PST) X-Google-Smtp-Source: AGs4zMbzz6cFVV/g/MKBUsMNCkWCZdKB7r+cjhxtCWJpid5gnBX4jd3ogO37ZvDIJmBmPJHLd5to X-Received: by 10.84.164.104 with SMTP id m37mr10356188plg.98.1511409818180; Wed, 22 Nov 2017 20:03:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511409818; cv=none; d=google.com; s=arc-20160816; b=PWKTHlBnNPxhKPi/he6+VxqLX+FGxg5zwKaVvtfKZFFV2b3PPOSbMtLIbRzMYKju/h C3ftC1Q9erEzR20sa0dFdv7kqZDBqTCFMCWDxJdM3dolJ/9MO8h7v21okc+GOGPb80RF CGqfU6sT5/+zX/vi2ai1IadOKrBqEStmT4LTtq2DexTEsmMyMc97LkFueZPp3r2A8rBi fm/+GwXQcs/Lewp7BXJHQpLzKt141aLfs3YK/jVpseSG4gPiFsg0HX0Yv4q7ZXWAsOvK yUWkEd4afgF1VzGBf/0/XXZIDwH2lsqjRZsoYn5+hYBCINRnw6i+4hPQ4PfVIp/FL4EI v8rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=g9uExOv0JqCKbLfHvwJB089XdX+CDUi+PV8O/bnY+iM=; b=xI63Zz2MJH8KRiByicD9+jrUsOPzVufTo3jx3kymmw5NNQ3MyLAeM1t9QHDtZ1Tuub xzewoGohJKVz3ftOByeufl5psqZQkb5jdpIZVMpPy1qAW9JPZCq+RJ4iNM0PgLMtAPmQ q+IT8NdLohqbSvBCSYJh0Ap87mFdMlyOeOJR/PFX1CZ+mvXl52LAp/DMXPOWGjiQ60wa OU/Dnq6Xscr4o6950Jz5NSWfRK6CE3GBMdGnbkjkFxNuEP+eJhc+xI5u7DjE/mjixsT7 9/M1k+4LyQC95FIPrFvtTSFbikfkh277dOw2vPut3wDVJHG+M3Berj/ki820a6YHRF9l rQLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=MjQ0Tg8D; dkim=pass header.i=@codeaurora.org header.s=default header.b=kIuwDoYe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1si15037649plj.141.2017.11.22.20.03.27; Wed, 22 Nov 2017 20:03:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=MjQ0Tg8D; dkim=pass header.i=@codeaurora.org header.s=default header.b=kIuwDoYe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752556AbdKWECe (ORCPT + 77 others); Wed, 22 Nov 2017 23:02:34 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:44388 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752133AbdKWECc (ORCPT ); Wed, 22 Nov 2017 23:02:32 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 3D04060730; Thu, 23 Nov 2017 04:02:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1511409752; bh=X0Sh6xmcgijBT6sq8O1otcfK3zMhSAILzIb5zF8sk5s=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=MjQ0Tg8Dovo2/2ml0FQ/fmPRATzO1N8URjkymcNw/MooAAy/tkpbzCuS9SsAV4Qiv 0ju21J3WZrz9idQ3N58poZAZ95tFwMQqGs4kizlSzItK4n2GDbdpCOJXH1Wbr7ER/v TFDFlCWp4e0ajV3zbp6mS7z0DW1njGJCb+O7aW/0= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [10.206.25.65] (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgautam@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id B69D86044B; Thu, 23 Nov 2017 04:02:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1511409751; bh=X0Sh6xmcgijBT6sq8O1otcfK3zMhSAILzIb5zF8sk5s=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=kIuwDoYeXK844ZU4SsRwCVgjtSprzmVWQ8uVpKqbhVehFKCx3QhdGeluAh7hMDWIp GNqs5U+a615wkAsHHqMDif1+cx/6Bt62bwf2pBwxhZNyxIGzGhExJqN26y7Mt/5ppv 9UvTx+lgNaTsLIsT1/3drkgyTUNe199ZqRM4PKBg= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B69D86044B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=mgautam@codeaurora.org Subject: Re: [PATCH v3 10/16] phy: qcom-qmp: Move register offsets to header file To: Stephen Boyd , Kishon Vijay Abraham I Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, Vivek Gautam , Varadarajan Narayanan , Wei Yongjun , Fengguang Wu , open list References: <1511256206-1587-1-git-send-email-mgautam@codeaurora.org> <1511256206-1587-11-git-send-email-mgautam@codeaurora.org> From: Manu Gautam Message-ID: <4ee6af23-7b09-c25b-9e79-f08373a88826@codeaurora.org> Date: Thu, 23 Nov 2017 09:32:26 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 11/22/2017 10:56 PM, Stephen Boyd wrote: > On 11/21/2017 01:23 AM, Manu Gautam wrote: >> New revision (v3) of QMP PHY uses different offsets >> for almost all of the registers. Hence, move these >> definitions to header file so that updated offsets >> can be added for QMP v3. >> >> Signed-off-by: Manu Gautam >> --- > Why? It would only be included into one C file so it's really not necessary. Yes, it is not necessary but it keep QMP PHY driver clean. V3 PHY duplicates all the #defines and this could continue for future revisions as well. Please refer to this patch:  - [PATCH v3 11/16] phy: qcom-qmp: Add register offsets for QMP V3 PHY -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project From 1584788061551957265@xxx Wed Nov 22 17:27:51 +0000 2017 X-GM-THRID: 1584667162035868026 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread