Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
From:   Nick Desaulniers <nick.desaulniers@gmail.com>
Date:   Wed, 22 Nov 2017 23:32:52 -0800
Message-ID: <CAH7mPviCKivZLkut6DcKz3hvKkMkrFyaenPi0aCbGJ+-97fO0Q@mail.gmail.com>
Subject: constant conversion warning in umip
To:     ricardo.neri-calderon@linux.intel.com
Cc:     bp@suse.de, Thomas Gleixner <tglx@linutronix.de>, mst@redhat.com,
        dave.hansen@linux.intel.com, ricardo.neri@intel.com,
        adrian.hunter@intel.com, paul.gortmaker@windriver.com,
        ray.huang@amd.com, qiaowei.ren@intel.com, shuah@kernel.org,
        Kees Cook <keescook@chromium.org>, corbet@lwn.net,
        jslaby@suse.cz, dvyukov@google.com, ravi.v.shankar@intel.com,
        cmetcalf@mellanox.com, brgerst@gmail.com, acme@redhat.com,
        luto@kernel.org, colin.king@canonical.com, slaoub@gmail.com,
        adam.buchbinder@gmail.com, vbabka@suse.cz,
        Lorenzo Stoakes <lstoakes@gmail.com>, mhiramat@kernel.org,
        Paolo Bonzini <pbonzini@redhat.com>, akpm@linux-foundation.org,
        thgarnie@google.com,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Pulling down ToT, I'm seeing the following warning when building with clang:

  CC      arch/x86/lib/insn.o
arch/x86/lib/insn-eval.c:780:10: error: implicit conversion from 'int'
to 'char' changes value from 132 to -124
[-Werror,-Wconstant-conversion]
                return INSN_CODE_SEG_PARAMS(4, 8);
                ~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~
./arch/x86/include/asm/insn-eval.h:16:57: note: expanded from macro
'INSN_CODE_SEG_PARAMS'
#define INSN_CODE_SEG_PARAMS(oper_sz, addr_sz) (oper_sz | (addr_sz << 4))
                                                ~~~~~~~~^~~~~~~~~~~~~~~~

seems to be coming from commit 4efea85fb56fa "x86/insn-eval: Add
function to get default params of code segment".  Should this be an
unsigned char (as well as seg_defs in arch/x86/kernel/umip.c?  That
might be an issue for returning -EINVAL, maybe an in/out parameter
would be better?

From 1584847669165191397@xxx Thu Nov 23 09:15:17 +0000 2017
X-GM-THRID: 1584080649720877136
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread