Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20171117141939.GD17880@kroah.com>
References: <20171117141939.GD17880@kroah.com>
From:   Philippe Ombredanne <pombredanne@nexb.com>
Date:   Fri, 17 Nov 2017 15:52:53 +0100
Message-ID: <CAOFm3uHNZ6B0gMn5SbZbq9z_Mkv8syqMUFmrp0mGiARK-ei8WQ@mail.gmail.com>
Subject: Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Andreas Kemnade <andreas@kemnade.info>,
        Johan Hovold <johan@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, linux-usb@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Nov 17, 2017 at 3:19 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> There is no need to #define the license of the driver, just put it in
> the MODULE_LICENSE() line directly as a text string.
>
> This allows tools that check that the module license matches the source
> code license to work properly, as there is no need to unwind the
> unneeded dereference.
>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Andreas Kemnade <andreas@kemnade.info>
> Cc: Johan Hovold <johan@kernel.org>
> Reported-by: Philippe Ombredanne <pombredanne@nexb.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
-- 
Cordially
Philippe Ombredanne

From 1584341954256791576@xxx Fri Nov 17 19:17:10 +0000 2017
X-GM-THRID: 1584341954256791576
X-Gmail-Labels: Inbox,Category Promotions,HistoricalUnread