Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v1 3/9] perf util: Reconstruct rblist for supporting
 per-thread shadow stats
To:     Jin Yao <yao.jin@linux.intel.com>
Cc:     acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
        mingo@redhat.com, alexander.shishkin@linux.intel.com,
        Linux-kernel@vger.kernel.org, ak@linux.intel.com,
        kan.liang@intel.com, yao.jin@intel.com,
        Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
References: <1511189024-19908-1-git-send-email-yao.jin@linux.intel.com>
 <1511189024-19908-4-git-send-email-yao.jin@linux.intel.com>
From:   Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Date:   Wed, 22 Nov 2017 12:01:32 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <1511189024-19908-4-git-send-email-yao.jin@linux.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Message-Id: <d60a2182-26b0-7df9-db02-4b2b092effbd@linux.vnet.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 11/20/2017 08:13 PM, Jin Yao wrote:
> @@ -76,6 +97,17 @@ static struct rb_node *saved_value_new(struct rblist *rblist __maybe_unused,
>   	return &nd->rb_node;
>   }
>
> +static void saved_value_delete(struct rblist *rblist __maybe_unused,
> +			       struct rb_node *rb_node)
> +{
> +	struct saved_value *v = container_of(rb_node,
> +					     struct saved_value,
> +					     rb_node);
> +
> +	if (v)
> +		free(v);
> +}

Do we really need if(v) ?

Thanks,
Ravi


From 1584731064183450028@xxx Wed Nov 22 02:21:54 +0000 2017
X-GM-THRID: 1584566861527833455
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread