Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Vasyl Gomonovych <gomonovych@gmail.com>
To:     linux@armlinux.org.uk, alexander.h.duyck@intel.com,
        akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org
Cc:     linux-kernel@vger.kernel.org, gomonovych@gmail.com
Subject: [PATCH] ARM: dma-mapping:Fix ifnullfree.cocci warnings
Date:   Wed, 22 Nov 2017 16:17:23 +0100
Message-Id: <1511363843-26202-1-git-send-email-gomonovych@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

NULL check before some freeing functions is not needed.

arch/arm/common/dmabounce.c:573:2-18: WARNING: NULL check before freeing functions like kfree
arch/arm/common/dmabounce.c:575:2-18: WARNING: NULL check before freeing functions like kfree
Generated by: scripts/coccinelle/free/ifnullfree.cocci

Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
 arch/arm/common/dmabounce.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
index 9a92de63426f..dcdd80c7a543 100644
--- a/arch/arm/common/dmabounce.c
+++ b/arch/arm/common/dmabounce.c
@@ -569,10 +569,8 @@ void dmabounce_unregister_dev(struct device *dev)
 		BUG();
 	}
 
-	if (device_info->small.pool)
-		dma_pool_destroy(device_info->small.pool);
-	if (device_info->large.pool)
-		dma_pool_destroy(device_info->large.pool);
+	dma_pool_destroy(device_info->small.pool);
+	dma_pool_destroy(device_info->large.pool);
 
 #ifdef STATS
 	if (device_info->attr_res == 0)
-- 
1.9.1


From 1584733744870498922@xxx Wed Nov 22 03:04:30 +0000 2017
X-GM-THRID: 1584732623319555253
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread