Received: by 10.223.164.202 with SMTP id h10csp6063672wrb; Tue, 21 Nov 2017 21:46:33 -0800 (PST) X-Google-Smtp-Source: AGs4zMaetKgLsRaH6fgH5QJZz/OZaDFy4Rq5l8jJ0EJhiov5VbOq68VcoO+W4K9/Mm5rqtyjEIfE X-Received: by 10.99.178.77 with SMTP id t13mr19659880pgo.219.1511329593290; Tue, 21 Nov 2017 21:46:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511329593; cv=none; d=google.com; s=arc-20160816; b=0BXzJkpZeIA7/Hr2TltmJ7hBer/o4mru9TPmtCizxP2b1ZmCIy2L1TXK5O3ouDtvL3 KiyxCRouzgjeX3ZlwB9YYDRHx01poSmcYHx5apYNVc3gL1m1a0FDQJpP1gDE01vHQ/1K xrXwLbFTq0UxcP/szipha5RVv9NzwsOvn4syhvu10julbAhv/MlSaXl9uJFsUMTyNUe9 n2O9ST6J1ONTnhAB4VbH8pV29muLFE6nxlL/dwzsn7kZUcNLRYGnf7QBUd23aveFhCZc xwC4jkb5bWc6n4VdkEmLVDnCLoS4jurcep4f8YVcf/HYPVqvH7Ab9BNPzyCn8CeB/fwF D3wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=quHck4Rp6jyq8SbGpUOpjFGmQSx7uTfWZgn1Rm/BucU=; b=ThuHsMzxKItiCRujJ5WylDnxUFeS5r6zVXgsDPuSGNKmXyVlocgOfWoZbyyUX4y2Uc BAcLS84A76eMw/kFAVXfEmSypk7uD/4DAFAPt9rbbZcp0KXJTOlknFMwYtXVYZ+tgNuu iTkW5KUTfc0sPn5e9uMJ4U417dCWGLaPN5XqrnGl1uwfQ3RpDv37BCa7iRVvQ3XYi7ip anHObc8Yk4T2BAxfhL8Jvn4UUN1iglK08RxyukeDcVzCoOtMrlvHbioKnGd7DJQ7LGNQ Lol5jwlYPDGMFt8a5skwpWnwJ8BpG/p5/DUdvOhmr2mWSXaYAWFPM+uQL3Mwvvxz3qmz c9eg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=cO6Mqckn; dkim=pass header.i=@codeaurora.org header.s=default header.b=cO6Mqckn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q15si12385860pgc.579.2017.11.21.21.46.22; Tue, 21 Nov 2017 21:46:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=cO6Mqckn; dkim=pass header.i=@codeaurora.org header.s=default header.b=cO6Mqckn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751449AbdKVFpp (ORCPT + 76 others); Wed, 22 Nov 2017 00:45:45 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:36410 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751079AbdKVFpk (ORCPT ); Wed, 22 Nov 2017 00:45:40 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id E0AFB607E4; Wed, 22 Nov 2017 05:45:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1511329539; bh=TVPCvLkhCNcW9TebaCtixRftySfL697z35VxRp9vL+w=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=cO6MqcknR8wFxf60uh5DtqhNI3AhW5vxj9VLxIigLcp0vD7aOsk/YgYLz3maqEV8u EuSHVUFQkhaZP4sTpa4WKljOSE9/sAhApGm/HPvXEz0j/fns42hVVvEvhwWazpmarF kMuH6GzJyOrfANiIW+Q5DjjwzgOJvn/tosyyLh20= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [192.168.0.101] (cpe-72-177-20-249.austin.res.rr.com [72.177.20.249]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: timur@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 9007260818; Wed, 22 Nov 2017 05:45:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1511329539; bh=TVPCvLkhCNcW9TebaCtixRftySfL697z35VxRp9vL+w=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=cO6MqcknR8wFxf60uh5DtqhNI3AhW5vxj9VLxIigLcp0vD7aOsk/YgYLz3maqEV8u EuSHVUFQkhaZP4sTpa4WKljOSE9/sAhApGm/HPvXEz0j/fns42hVVvEvhwWazpmarF kMuH6GzJyOrfANiIW+Q5DjjwzgOJvn/tosyyLh20= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9007260818 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=timur@codeaurora.org Subject: Re: [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function To: Sinan Kaya , linux-pci@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bjorn Helgaas , open list References: <1511328675-21981-1-git-send-email-okaya@codeaurora.org> <1511328675-21981-31-git-send-email-okaya@codeaurora.org> From: Timur Tabi Message-ID: Date: Tue, 21 Nov 2017 23:45:37 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1511328675-21981-31-git-send-email-okaya@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/21/17 11:31 PM, Sinan Kaya wrote: > Use pci_get_domain_bus_and_slot() with a domain number of 0 where we can't > extract the domain number. Other places, use the actual domain number from > the device. > > Now that all users of pci_get_bus_and_slot() switched to > pci_get_domain_bus_and_slot(), it is now safe to remove this function. This doesn't really eliminate pci_get_bus_and_slot(), because it doesn't force developers to support non-zero domains. What's to stop a driver developer from doing this? #define pci_get_bus_and_slot(b, d) pci_get_domain_bus_and_slot(0, b, d) thereby completely ignoring what you're trying to do? -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. From 1584743149582609571@xxx Wed Nov 22 05:33:59 +0000 2017 X-GM-THRID: 1584743149582609571 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread