Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Benson Leung <bleung@chromium.org>
To:     broonie@kernel.org, linux-kernel@vger.kernel.org
Cc:     harshapriya.n@intel.com, naveen.m@intel.com,
        srinivas.kandagatla@linaro.org, cychiang@chromium.org,
        dgreid@chromium.org, anatol.pomozov@gmail.com, bleung@chromium.org,
        bleung@google.com
Subject: [PATCH 3/5] ASoC: ts3a227e: Map BTN_0 to KEY_PLAYPAUSE
Date:   Wed, 22 Nov 2017 12:56:41 -0800
Message-Id: <20171122205643.99783-4-bleung@chromium.org>
In-Reply-To: <20171122205643.99783-1-bleung@chromium.org>
References: <20171122205643.99783-1-bleung@chromium.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

The Android 3.5mm Headset jack specification mentions that BTN_0 should
be mapped to KEY_MEDIA, but this is less logical than KEY_PLAYPAUSE,
which has much broader userspace support.

For example, the Chrome OS userspace now supports KEY_PLAYPAUSE to toggle
play/pause of videos and audio, but does not handle KEY_MEDIA.

Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the
new USB headset spec requires KEY_PLAYPAUSE for BTN_0.
https://source.android.com/devices/accessories/headset/usb-headset-spec

Signed-off-by: Benson Leung <bleung@chromium.org>
---
 sound/soc/codecs/ts3a227e.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/ts3a227e.c b/sound/soc/codecs/ts3a227e.c
index 738e04b09116..1271e7e1fc78 100644
--- a/sound/soc/codecs/ts3a227e.c
+++ b/sound/soc/codecs/ts3a227e.c
@@ -241,7 +241,7 @@ int ts3a227e_enable_jack_detect(struct snd_soc_component *component,
 {
 	struct ts3a227e *ts3a227e = snd_soc_component_get_drvdata(component);
 
-	snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_MEDIA);
+	snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_PLAYPAUSE);
 	snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOICECOMMAND);
 	snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEUP);
 	snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOLUMEDOWN);
-- 
2.15.0.448.gf294e3d99a-goog


From 1584713690345198995@xxx Tue Nov 21 21:45:45 +0000 2017
X-GM-THRID: 1584713690345198995
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread