Received: by 10.223.164.202 with SMTP id h10csp225446wrb; Wed, 22 Nov 2017 06:19:47 -0800 (PST) X-Google-Smtp-Source: AGs4zMYG2y9NInJHzE7upwr5UM02uEDv0/ch9RNn/vb/x+LhsliNuhHighojQx+EguCZNaiorU4+ X-Received: by 10.99.111.139 with SMTP id k133mr1099806pgc.332.1511360387196; Wed, 22 Nov 2017 06:19:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511360387; cv=none; d=google.com; s=arc-20160816; b=QeeAnmXzTVGgcCL+0aFeSW9W1ZxcmPTuB59jiaNrIG6GQtinVpH1GjyAXQFVO7k+ej fnjB7c8mt9z9AyCdma9BSCKacBQ8HeIvkk6lbjdv7lYKl1LnBQf4ucnlbo/nLqN/IudC zEp/7buflJwC4dgDFxYsPFQ/Lm4ILVnThuW4rWO/ctbMFyywrhueT/KSxUJhlKMuN5q0 blSGwjGQzC0UiKW6yqWKysOp45m2bcnpZuxYNMJBeA6aVpsa0cxwa5p/GWzgkBBUnTcU YYM8pJ/iBRvLtVniDZNkPssN3uIFoDWQj5JOC3mJk+PLfkpfF3iOr4we0ZoPK6lL6pUF ReQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=zbF+jMAlKKKvr7Nw0NrZqEqx9pBSZOqGbyDDeiva46w=; b=QDcKvRVldpNO9CoQiB7oKWqSnZ6n6L4wJHHS2oVDLQX3glhxIQCrQz5GnI/GmQEWI4 n2d6cdOctXApx2I8LHvcXKXQ/qWPdzx5E0+0n8xJLTp9aTz89TOsaNzPQw5w3w00Mu7d m9RoJ8000/JVDEIwKLr7IPl58TstPxqVvR1zSIEdx800QF/SXcF4l3aWhqzDVSmFrR2/ QAZg+cHquBWhYv5FIZOhfFwd2LmrYSZnPPGobkzvVd77Q+mtechQS/EzwDTZp9rkwHYx 79U/xM7++afezj8QW1ScbRNbOMrhZen2QlwYJCF1pTAyCxLLMbaW84H62WPFnpOM3SvW e5tA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e80si15244684pfb.385.2017.11.22.06.19.34; Wed, 22 Nov 2017 06:19:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751371AbdKVOSy (ORCPT + 78 others); Wed, 22 Nov 2017 09:18:54 -0500 Received: from gateway22.websitewelcome.com ([192.185.47.179]:37252 "EHLO gateway22.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751260AbdKVOSx (ORCPT ); Wed, 22 Nov 2017 09:18:53 -0500 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 8866F120B0 for ; Wed, 22 Nov 2017 08:18:52 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id HVrYecnDUtuxmHVrYex86L; Wed, 22 Nov 2017 08:18:52 -0600 Received: from [189.175.14.138] (port=38418 helo=[192.168.1.69]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89) (envelope-from ) id 1eHVrY-002lHK-4U; Wed, 22 Nov 2017 08:18:52 -0600 Subject: Re: [PATCH] scsi: ufs: ufshcd: fix potential NULL pointer dereference in ufshcd_config_vreg To: "Martin K. Petersen" Cc: Vinayak Holikatti , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171120141229.GA2130@embeddedor.com> From: "Gustavo A. R. Silva" Message-ID: Date: Wed, 22 Nov 2017 08:18:45 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.175.14.138 X-Source-L: No X-Exim-ID: 1eHVrY-002lHK-4U X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.69]) [189.175.14.138]:38418 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 5 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/21/2017 10:01 PM, Martin K. Petersen wrote: > Gustavo A., > >> _vreg_ is being dereferenced before it is null checked, hence there is a >> potential null pointer dereference. >> >> Fix this by moving the pointer dereference after _vreg_ has been null >> checked. > Applied to 4.15/scsi-fixes, thank you! > Glad to help. :) Thanks -- Gustavo A. R. Silva From 1584737393419627170@xxx Wed Nov 22 04:02:30 +0000 2017 X-GM-THRID: 1584594679115361987 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread