Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20171120203449.GA16362@bhelgaas-glaptop.roam.corp.google.com>
References: <20171120193247.8187-1-romain.perier@gmail.com>
 <20171120193247.8187-6-romain.perier@gmail.com> <20171120203449.GA16362@bhelgaas-glaptop.roam.corp.google.com>
From:   Romain Perier <romain.perier@gmail.com>
Date:   Tue, 21 Nov 2017 09:39:04 +0100
Message-ID: <CABgxDoL=MTqLN3VSVKi9Kajn0q4ZfpxpZiyEeKAOWfpj4_wAOA@mail.gmail.com>
Subject: Re: [PATCH v15 5/5] PCI: Remove PCI pool macro functions
To:     Bjorn Helgaas <helgaas@kernel.org>
Cc:     Jens Axboe <axboe@kernel.dk>,
        Andrew Morton <akpm@linux-foundation.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Vinod Koul <vinod.koul@intel.com>,
        Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
        Aviad Krawczyk <aviad.krawczyk@huawei.com>,
        "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
        linux-pci@vger.kernel.org, dmaengine@vger.kernel.org,
        netdev <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Romain Perier <romain.perier@collabora.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Whoops, my bad. Sorry

Thanks,
Romain

2017-11-20 21:34 GMT+01:00 Bjorn Helgaas <helgaas@kernel.org>:
> On Mon, Nov 20, 2017 at 08:32:47PM +0100, Romain Perier wrote:
>> From: Romain Perier <romain.perier@collabora.com>
>>
>> Now that all the drivers use dma pool API, we can remove the macro
>> functions for PCI pool.
>>
>> Signed-off-by: Romain Perier <romain.perier@collabora.com>
>> Reviewed-by: Peter Senna Tschudin <peter.senna@collabora.com>
>
> I already acked this once on Oct 24.  Please keep that ack and include
> it in any future postings so I don't have to deal with this again.
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
>
>> ---
>>  include/linux/pci.h | 9 ---------
>>  1 file changed, 9 deletions(-)
>>
>> diff --git a/include/linux/pci.h b/include/linux/pci.h
>> index 96c94980d1ff..d03b4a20033d 100644
>> --- a/include/linux/pci.h
>> +++ b/include/linux/pci.h
>> @@ -1324,15 +1324,6 @@ int pci_set_vga_state(struct pci_dev *pdev, bool decode,
>>  #include <linux/pci-dma.h>
>>  #include <linux/dmapool.h>
>>
>> -#define      pci_pool dma_pool
>> -#define pci_pool_create(name, pdev, size, align, allocation) \
>> -             dma_pool_create(name, &pdev->dev, size, align, allocation)
>> -#define      pci_pool_destroy(pool) dma_pool_destroy(pool)
>> -#define      pci_pool_alloc(pool, flags, handle) dma_pool_alloc(pool, flags, handle)
>> -#define      pci_pool_zalloc(pool, flags, handle) \
>> -             dma_pool_zalloc(pool, flags, handle)
>> -#define      pci_pool_free(pool, vaddr, addr) dma_pool_free(pool, vaddr, addr)
>> -
>>  struct msix_entry {
>>       u32     vector; /* kernel uses to write allocated vector */
>>       u16     entry;  /* driver uses to specify entry, OS writes */
>> --
>> 2.14.1
>>

From 1584618683612957474@xxx Mon Nov 20 20:35:39 +0000 2017
X-GM-THRID: 1584614813417275396
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread