Date: Sun, 13 Jan 2008 16:29:59 +0000
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Robert Hancock <hancockr@shaw.ca>, Alexander <aledin@mail.ru>,
       linux-kernel@vger.kernel.org, ide <linux-ide@vger.kernel.org>,
       Jeff Garzik <jeff@garzik.org>, Tejun Heo <htejun@gmail.com>
Subject: Re: PROBLEM REMAINS: [sata_nv ADMA breaks ATAPI] Crash	on	accessing
 DVD-RAM
Message-ID: <20080113162959.01d519db@lxorguk.ukuu.org.uk>
In-Reply-To: <1200238725.3179.16.camel@localhost.localdomain>
References: <fa.krOVfyFmB2aqGjJIoHCLmQxecWc@ifi.uio.no>
	<478702C7.80401@shaw.ca>
	<47887982.6050805@mail.ru>
	<47891426.1020604@shaw.ca>
	<1200170117.3656.66.camel@localhost.localdomain>
	<47894785.2050508@shaw.ca>
	<1200180440.3656.76.camel@localhost.localdomain>
	<47896BA8.4030609@shaw.ca>
	<20080113133317.50ad4bda@lxorguk.ukuu.org.uk>
	<1200238725.3179.16.camel@localhost.localdomain>
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street,
 Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a
 Lloegr o'r rhif cofrestru 3798903
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 809
Lines: 15

> Yes, I concur for the short term.  The other two possible courses of
> action either involve long discussions (the different device one) or
> you'll never quite be sure you got all the paths (the GFP_DMA32 one).
> At least with this one, you know everything will work.

The different device one is tricky because the PCI layer is involved in
mapping on some systems so you can't just magic up a platform device for
it. Putting a mask on the block queue might perhaps work as a model
which avoids breaking stuff by suprise, with the device left at 32bit
masking.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/