Received: by 10.223.164.202 with SMTP id h10csp1821386wrb; Sat, 18 Nov 2017 06:57:05 -0800 (PST) X-Google-Smtp-Source: AGs4zMYs9N6uENTOhiwb64ax7ohytwsA5L9LroZBcebI+PcZwXi4O15fx0gJWSKdLEq+ljHPQHid X-Received: by 10.99.8.5 with SMTP id 5mr8364637pgi.28.1511017025487; Sat, 18 Nov 2017 06:57:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511017025; cv=none; d=google.com; s=arc-20160816; b=mJwUpJd9T9W+uhZTBGNXO3PBlWEsNZEPc5uZ4Ue66lRONM+I7GmMiwBKqcWQv4IrCd jyA9WlgppsLC4Togb6w2AGlzUjXHg8Ao8RW5SepNq+mCLTAUuVnTHh0BZW/I1g2c2rtZ arn0O7pnfBJqhxJU1DIDWGHNhTpONecxsiUdlacxcWR8+w7B+O9CqsZhNGfyWAX7Raws yjJdNc08j2G0UyHj9zrO/7J/bE6wohiy/dhPGmGyE+ovE98ZLvnlPG+4Ph8tvX3dL8/w 43aSoBdRS5fRuTd2zhpin76SepvIYYyW3WPoIlWEBmNg/upH9e6xC9/lJggpz1C1AMdW l6Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date :arc-authentication-results; bh=xlLvqTx2oYU0MmMyKdeu5oYUONCfFKp5rp7PH9oHkY0=; b=fHezvrBX0Erj3ofcBT4KfJuny2WGoJGhDikuzcnwIfhEMAky8tcgiY2hzXuX9OzJ9i NSRM8Ke7Q5d3YudZsk2Hjb3d0y6TLXnLCKocRYUlepzrb4lhxlrf9RV4sygQOw88XGMu P0wXE4OkDGVRAY327IFiwqpE64F+VxkCFY7hJQgJuCqTXuPqQgW/sDGsgMt9QNLfRBBW vtu28m6RqPS0BzG27b57yw9T8CRhGz/pv/GzfF5Bqkq0MTW4aSnYV7EOB19DEAcLjs6Z gHNyHndcmVneRMbj6Y5lObfhH6jGBVB+cc08ISjSE4rdHNRcFPDaW78+O4mg6eRlbzY8 qDNQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a63si4704558pla.727.2017.11.18.06.56.52; Sat, 18 Nov 2017 06:57:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422940AbdKQWkl (ORCPT + 93 others); Fri, 17 Nov 2017 17:40:41 -0500 Received: from gateway23.websitewelcome.com ([192.185.48.84]:14299 "EHLO gateway23.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966746AbdKQWke (ORCPT ); Fri, 17 Nov 2017 17:40:34 -0500 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway23.websitewelcome.com (Postfix) with ESMTP id E862111B3B for ; Fri, 17 Nov 2017 16:40:33 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id FpJJe6SrhtuxmFpJJeRbfp; Fri, 17 Nov 2017 16:40:33 -0600 Received: from [189.175.248.21] (port=36078 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.87) (envelope-from ) id 1eFpJJ-001CDZ-JQ; Fri, 17 Nov 2017 16:40:33 -0600 Date: Fri, 17 Nov 2017 16:40:32 -0600 From: "Gustavo A. R. Silva" To: David Howells Cc: linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] afs: cell: Remove unnecessary code in afs_lookup_cell Message-ID: <20171117224032.GA18454@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.175.248.21 X-Source-L: No X-Exim-ID: 1eFpJJ-001CDZ-JQ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.175.248.21]:36078 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 6 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Due to recent changes this piece of code is no longer needed. Addresses-Coverity-ID: 1462033 Link: https://lkml.kernel.org/r/4923.1510957307@warthog.procyon.org.uk Signed-off-by: Gustavo A. R. Silva --- fs/afs/cell.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/afs/cell.c b/fs/afs/cell.c index 1858c91..9bb921d 100644 --- a/fs/afs/cell.c +++ b/fs/afs/cell.c @@ -207,13 +207,8 @@ struct afs_cell *afs_lookup_cell(struct afs_net *net, rcu_read_lock(); cell = afs_lookup_cell_rcu(net, name, namesz); rcu_read_unlock(); - if (!IS_ERR(cell)) { - if (excl) { - afs_put_cell(net, cell); - return ERR_PTR(-EEXIST); - } + if (!IS_ERR(cell)) goto wait_for_cell; - } } /* Assume we're probably going to create a cell and preallocate and -- 2.7.4 From 1584581523041617742@xxx Mon Nov 20 10:45:00 +0000 2017 X-GM-THRID: 1584466357559309633 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread