Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 3/3] net: ethernet: fec: fix refclk enable for SMSC
 LAN8710/20
To:     Geert Uytterhoeven <geert@linux-m68k.org>
CC:     Andy Duan <fugang.duan@nxp.com>,
        "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        Richard Leitner <dev@g0hl1n.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Sergei Shtylyov" <sergei.shtylyov@cogentembedded.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>
References: <20171120083417.32558-1-dev@g0hl1n.net>
 <20171120083417.32558-4-dev@g0hl1n.net>
 <AM4PR0401MB2260C817E1670ADB5E9DA070FF220@AM4PR0401MB2260.eurprd04.prod.outlook.com>
 <6cab10d6-8311-f34a-5eb7-ccca3c48a527@skidata.com>
 <AM4PR0401MB226017D0B26CA22E43D4F810FF220@AM4PR0401MB2260.eurprd04.prod.outlook.com>
 <30a94c72-2345-0649-6682-4826d31c3285@skidata.com>
 <CAMuHMdWK40m5zjFXrFJXMsfa+HqgHgJxFmXALn6nDTZzcKq28g@mail.gmail.com>
From:   Richard Leitner <richard.leitner@skidata.com>
Message-ID: <05754f2b-3765-bf90-40ff-a2e8337ddcce@skidata.com>
Date:   Mon, 20 Nov 2017 14:21:51 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CAMuHMdWK40m5zjFXrFJXMsfa+HqgHgJxFmXALn6nDTZzcKq28g@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 11/20/2017 02:13 PM, Geert Uytterhoeven wrote:
> Hi Richard,
> 
> On Mon, Nov 20, 2017 at 1:55 PM, Richard Leitner
> <richard.leitner@skidata.com> wrote:
>> On 11/20/2017 11:35 AM, Andy Duan wrote:
>>> 3. add reset gpio descriptor for common phy device driver.
>>
>> ... if I understood it correctly the patch called "Teach phylib
>> hard-resetting devices" by Geert and Sergei is exactly doing this:
>>         https://patchwork.ozlabs.org/cover/828503/
>>         https://lkml.org/lkml/2017/10/20/166
>>
>> So I'll implement the phy_reset_after_clk_enable function atop of this
>> patch-set and add a note that my patch-series depends on it. Would that
>> be OK?
> 
> I will update and respin that patch series after the merge window has closed.

Ok. Thank you for the quick response an this information.

For the Freescale Fast Ethernet Controller (FEC) there are currently (in
addition to the reset gpio) two additional optional dt properties for
the reset:
 - phy-reset-duration : Reset duration in milliseconds.
 - phy-reset-post-delay : Post reset delay in milliseconds.

IMHO it would make sense to include them also in the phylib
implementation. What do you think about it? Should I include it in my
patch-series?

kind regards;
Richard.L

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 

From 1584590938971472482@xxx Mon Nov 20 13:14:40 +0000 2017
X-GM-THRID: 1584573446575200827
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread