Received: by 10.223.164.202 with SMTP id h10csp1088329wrb; Fri, 17 Nov 2017 13:45:02 -0800 (PST) X-Google-Smtp-Source: AGs4zMZBMm92vgXVOTkWpX9sc7oFkFFpLePjHBtH/usM9+ecjX80ieMh4tt0+ZwFGl0RQyCC6QiK X-Received: by 10.84.251.146 with SMTP id w18mr2696081pll.324.1510955102709; Fri, 17 Nov 2017 13:45:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510955102; cv=none; d=google.com; s=arc-20160816; b=yHP4rJogYW04KWVVwjpr2qqfhFba2cngb8E5fGBF8tXSuRR32pWpxXIxiP2NP1GNL2 n/oPXy5hFeinm1U8iRva6t1TuKQvPqGBoqqf6DGk0xkWRHWrbzJtPtYUP1ujcBGvHBSt G2CWTGE7RROO3hIyFQee6i5K0Jt0WkLiEZcEVzXGDmbw9dFhU77KopPSh/TjOVEfrwgm AaplNgezPJE4AV5wl3x3uoTcV5XnnK/7ffERaa9U5A0GECURnzpdjIedaEEsgCOZ/jze +3e2aJ501p3e1I1n8kbotyfvyNIdXNlQb8G2rnMNKBhRg+Bq+KRFj18K2z1gRRWJHPCp nvAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:arc-authentication-results; bh=e3x/1P5soAVd8DSqQ/w364rSngB58IwUkXHIB3w6Czs=; b=XGW+N5a0xpMP3r5AcBVOVW1/Xmg/EGEU4g3kZ1ECiM/oh6t13GSKKV1EGiqlUbf/aF NX6DppIpMnw4OmJMzW7/aIHhGnbcGeHWDIjc1BkHSUY8VE1sdllug7Q6Lzq04bqiN8JY ZIsWogaXuWE7R0eZVJOa6fleh+ODxAETYfSIcxf4xSeWzbOl0TVjcM8lIA2WWYGbT8un KMIWUIHc1eqkPEzITfRREs0zSkFIOPWdYsA6oiBfePJgx6oQ6YsQF6lrcwNHKrRRboas JlwiJv12+SKD2/Ec28nSFQBZNZnoil9EQDnPpxYXm1EcwzTYgJqQhjiegyQzPc+yS+BZ yR3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=samsung.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o1si3320349plk.182.2017.11.17.13.44.49; Fri, 17 Nov 2017 13:45:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934479AbdKQNAo (ORCPT + 93 others); Fri, 17 Nov 2017 08:00:44 -0500 Received: from osg.samsung.com ([64.30.133.232]:63984 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932840AbdKQNAh (ORCPT ); Fri, 17 Nov 2017 08:00:37 -0500 Received: from localhost (localhost [127.0.0.1]) by osg.samsung.com (Postfix) with ESMTP id 1DD752B3C2; Fri, 17 Nov 2017 05:00:37 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at dev.s-opensource.com Received: from osg.samsung.com ([127.0.0.1]) by localhost (localhost [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JPDa6dFs-uLT; Fri, 17 Nov 2017 05:00:30 -0800 (PST) Received: from vento.lan (177.17.214.168.dynamic.adsl.gvt.net.br [177.17.214.168]) by osg.samsung.com (Postfix) with ESMTPSA id 14FE12B3B9; Fri, 17 Nov 2017 05:00:27 -0800 (PST) Date: Fri, 17 Nov 2017 11:00:25 -0200 From: Mauro Carvalho Chehab To: Alexandre Courbot Cc: Gustavo Padovan , , Hans Verkuil , Shuah Khan , Pawel Osciak , Sakari Ailus , Brian Starkey , Thierry Escande , , Gustavo Padovan Subject: Re: [RFC v5 07/11] [media] vb2: add in-fence support to QBUF Message-ID: <20171117110025.2a49db49@vento.lan> In-Reply-To: <422c5326-374b-487f-9ef1-594f239438f1@chromium.org> References: <20171115171057.17340-1-gustavo@padovan.org> <20171115171057.17340-8-gustavo@padovan.org> <422c5326-374b-487f-9ef1-594f239438f1@chromium.org> Organization: Samsung X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, 17 Nov 2017 15:49:23 +0900 Alexandre Courbot escreveu: > > @@ -178,6 +179,12 @@ static int vb2_queue_or_prepare_buf(struct > > vb2_queue *q, struct v4l2_buffer *b, > > return -EINVAL; > > } > > > > + if ((b->fence_fd != 0 && b->fence_fd != -1) && > > Why do we need to consider both values invalid? Can 0 ever be a valid fence > fd? Programs that don't use fences will initialize reserved2/fence_fd field at the uAPI call to zero. So, I guess using fd=0 here could be a problem. Anyway, I would, instead, do: if ((b->fence_fd < 1) && ... as other negative values are likely invalid as well. -- Thanks, Mauro From 1584351248944397422@xxx Fri Nov 17 21:44:54 +0000 2017 X-GM-THRID: 1584155088810136583 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread