Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20171120160853.2a1bb7b2@alans-desktop>
References: <20171102182950.6129-1-romain.perier@gmail.com>
 <dd52374f-af2d-3ff1-b9cf-fbf28634a739@sony.com> <CABgxDoKm3PZuzV9H=jFnMOQoxKg2_byA7kane-kDhcVEwd9FJw@mail.gmail.com>
 <24617dd4-66ed-d7c9-4c2c-8ad2faac7b72@sony.com> <20171120160853.2a1bb7b2@alans-desktop>
From:   Romain Perier <romain.perier@gmail.com>
Date:   Mon, 20 Nov 2017 17:29:53 +0100
Message-ID: <CABgxDoKXJSkx88XAN=pcL25GJtevM7wkEn4AbigZr1CYKrAWyg@mail.gmail.com>
Subject: Re: [PATCH] time: Make NTP optionnal
To:     Alan Cox <gnomes@lxorguk.ukuu.org.uk>
Cc:     peter enderborg <peter.enderborg@sony.com>,
        John Stultz <john.stultz@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Stephen Boyd <sboyd@codeaurora.org>, linux-api@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

So even if the correspondong syscall are disabled and the
corresponding clocks too, you should return an -ENOSYS from the
do_adjtimex helper, in case that another component tries to use it in
the kernel, right ?

Regards,
Romain

2017-11-20 17:08 GMT+01:00 Alan Cox <gnomes@lxorguk.ukuu.org.uk>:
> On Mon, 20 Nov 2017 16:22:06 +0100
> peter enderborg <peter.enderborg@sony.com> wrote:
>
>> On 11/20/2017 04:00 PM, Romain Perier wrote:
>> > Hi,
>> >
>> > 2017-11-20 15:10 GMT+01:00 peter enderborg <peter.enderborg@sony.com>:
>> >> I think it should return a error code at least.
>> > In which case ? The idea was to don't change the behaviour of these
>> > functions (from the "API" point of view) and to avoid regressions in
>> > the kernel components that depend on these NTP feature.
>> > (so be transparent the most as possible)
>> >
>> > Thanks,
>> > Romain
>> >
>>
>> do_adjtimex should return -ENOSYS in my opinion, however it is not in the manual
>> that it can return ENOSYS.
>
> The standards specifications state what must be returned for certain
> error cases, they don't forbid other errors being added.
>
> Old old Linx will of course already return -1,ENOSYS to this call.
>
> Alan

From 1584601966686330371@xxx Mon Nov 20 16:09:57 +0000 2017
X-GM-THRID: 1582980106532233430
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread