Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20171117141632.GA17880@kroah.com>
References: <20171117141632.GA17880@kroah.com>
From:   Philippe Ombredanne <pombredanne@nexb.com>
Date:   Fri, 17 Nov 2017 15:50:25 +0100
Message-ID: <CAOFm3uF11SPkt4cUnHd4=+Xmy7-oJeNcBBSPii_tjHtLkM-5Tw@mail.gmail.com>
Subject: Re: [PATCH] gpu: gma500: remove unneeded DRIVER_LICENSE #define
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Patrik Jakobsson <patrik.r.jakobsson@gmail.com>,
        David Airlie <airlied@linux.ie>,
        dri-devel@lists.freedesktop.org,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Nov 17, 2017 at 3:16 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> There is no need to #define the license of the driver, just put it in
> the MODULE_LICENSE() line directly as a text string.
>
> This allows tools that check that the module license matches the source
> code license to work properly, as there is no need to unwind the
> unneeded dereference, especially when the string is defined in a .h file
> far away from the .c file it is used in.
>
> Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
> Cc: David Airlie <airlied@linux.ie>
> Reported-by: Philippe Ombredanne <pombredanne@nexb.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>

-- 
Cordially
Philippe Ombredanne

From 1584346781492968359@xxx Fri Nov 17 20:33:53 +0000 2017
X-GM-THRID: 1584346781492968359
X-Gmail-Labels: Inbox,Category Promotions,HistoricalUnread