Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] drm/amd/display/dc/dce110/dce110_mem_input_v: use swap
 macro in program_size_and_rotation
To:     "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        David Airlie <airlied@linux.ie>
Cc:     dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20171110223109.GA31549@embeddedor.com>
From:   Harry Wentland <harry.wentland@amd.com>
Message-ID: <fc996517-7d2b-a35a-1a2d-930037668dac@amd.com>
Date:   Fri, 17 Nov 2017 10:45:29 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171110223109.GA31549@embeddedor.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2017 15:45:33.3798 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d378eb50-75f1-442d-bfc9-08d52dd23e75
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB2469
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2017-11-10 05:31 PM, Gustavo A. R. Silva wrote:
> Make use of the swap macro instead of _manually_ swapping values
> and remove unnecessary variable swap.
> 
> This makes the code easier to read and maintain.
> 
> This code was detected with the help of Coccinelle.
> 
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  .../drm/amd/display/dc/dce110/dce110_mem_input_v.c | 28 +++++++---------------
>  1 file changed, 8 insertions(+), 20 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c
> index a06c602..7bab8c6 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c
> @@ -237,26 +237,14 @@ static void program_size_and_rotation(
>  	if (rotation == ROTATION_ANGLE_90 ||
>  		rotation == ROTATION_ANGLE_270) {
>  
> -		uint32_t swap;
> -		swap = local_size.video.luma_size.x;
> -		local_size.video.luma_size.x =
> -			local_size.video.luma_size.y;
> -		local_size.video.luma_size.y  = swap;
> -
> -		swap = local_size.video.luma_size.width;
> -		local_size.video.luma_size.width =
> -			local_size.video.luma_size.height;
> -		local_size.video.luma_size.height = swap;
> -
> -		swap = local_size.video.chroma_size.x;
> -		local_size.video.chroma_size.x =
> -			local_size.video.chroma_size.y;
> -		local_size.video.chroma_size.y  = swap;
> -
> -		swap = local_size.video.chroma_size.width;
> -		local_size.video.chroma_size.width =
> -			local_size.video.chroma_size.height;
> -		local_size.video.chroma_size.height = swap;
> +		swap(local_size.video.luma_size.x,
> +		     local_size.video.luma_size.y);
> +		swap(local_size.video.luma_size.width,
> +		     local_size.video.luma_size.height);
> +		swap(local_size.video.chroma_size.x,
> +		     local_size.video.chroma_size.y);
> +		swap(local_size.video.chroma_size.width,
> +		     local_size.video.chroma_size.height);
>  	}
>  
>  	value = 0;
> 

From 1583720065663500250@xxx Fri Nov 10 22:32:31 +0000 2017
X-GM-THRID: 1583720065663500250
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread