Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 19 Nov 2017 12:40:53 +0900 (KST)
Message-Id: <20171119.124053.892184966822585016.davem@davemloft.net>
To:     laoar.shao@gmail.com
Cc:     kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, rostedt@goodmis.org,
        songliubraving@fb.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net-next] net/tcp: trace all TCP/IP state transition
 with tcp_set_state tracepoint
From:   David Miller <davem@davemloft.net>
In-Reply-To: <1511019156-22039-1-git-send-email-laoar.shao@gmail.com>
References: <1511019156-22039-1-git-send-email-laoar.shao@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Yafang Shao <laoar.shao@gmail.com>
Date: Sat, 18 Nov 2017 15:32:36 +0000

> The TCP/IP transition from TCP_LISTEN to TCP_SYN_RECV and some other
> transitions are not traced with tcp_set_state tracepoint.
> 
> In order to trace the whole tcp lifespans, two helpers are introduced,
> void __tcp_set_state(struct sock *sk, int state)
> void __sk_state_store(struct sock *sk, int newstate)
> 
> When do TCP/IP state transition, we should use these two helpers or use
> tcp_set_state() other than assigning a value to sk_state directly.
> 
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>

Please resubmit this when the net-next tree opens back up as it is
closed right now.

Thank you.

From 1584466659914554474@xxx Sun Nov 19 04:19:18 +0000 2017
X-GM-THRID: 1584466239707830390
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread