Date: Mon, 14 Jan 2008 00:49:59 +0000
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: nigel@nigel.suspend2.net
Cc: nigel@suspend2.net, Pavel Machek <pavel@ucw.cz>,
       Russell King <rmk+lkml@arm.linux.org.uk>,
       Linux Kernel List <linux-kernel@vger.kernel.org>,
       Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH: 2/2] [SERIAL] avoid stalling suspend if serial port
 won't drain
Message-ID: <20080114004959.0f533fef@lxorguk.ukuu.org.uk>
In-Reply-To: <478A95DB.80407@suspend2.net>
References: <20080108115148.GB10546@flint.arm.linux.org.uk>
	<20080108115703.GA27179@flint.arm.linux.org.uk>
	<20080111101721.GA4463@ucw.cz>
	<478A95DB.80407@suspend2.net>
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street,
 Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a
 Lloegr o'r rhif cofrestru 3798903
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 804
Lines: 16

> > Is printk() enough for 'we've just lost your data' condition? Maybe we
> > should abort suspend if we can't drain fifo?
> 
> No way. Think about this from a users' perspective. No one wants suspend
> to ram or hibernate functionality that works sometimes and not others.
> They want it to work reliably so they don't have to worry about their
> laptop overheating while they're getting on the bus or airplane.
> Aborting isn't an option.

Dumb question on the printk however - what if the port that is sticking
is the console - don't we recurse and die ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/