Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Trond Myklebust <trond.myklebust@primarydata.com>
To:     Anna Schumaker <anna.schumaker@netapp.com>
Cc:     Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        "linux-nfs @ vger . kernel . org" <linux-nfs@vger.kernel.org>,
        "linux-kernel @ vger . kernel . org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] NFSv4: Ensure gcc 4.4.4 can compile initialiser for "invalid_stateid"
Date:   Sat, 18 Nov 2017 13:50:11 -0500
Message-Id: <20171118185011.4729-1-trond.myklebust@primarydata.com>
In-Reply-To: <cce6f1be-0481-4ecc-85e2-a626cf381ce3@oracle.com>
References: <cce6f1be-0481-4ecc-85e2-a626cf381ce3@oracle.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

gcc 4.4.4 is too old to have full C11 anonymous union support, so
the current initialiser fails to compile.

Reported-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
---
 fs/nfs/nfs4state.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
index 980462d577ca..231b5ea2464a 100644
--- a/fs/nfs/nfs4state.c
+++ b/fs/nfs/nfs4state.c
@@ -71,8 +71,8 @@ const nfs4_stateid zero_stateid = {
 };
 const nfs4_stateid invalid_stateid = {
 	{
-		.seqid = cpu_to_be32(0xffffffffU),
-		.other = { 0 },
+		/* Funky initialiser keeps older gcc versions happy */
+		.data = { 0xff, 0xff, 0xff, 0xff, 0 },
 	},
 	.type = NFS4_INVALID_STATEID_TYPE,
 };
-- 
2.14.3


From 1584463513735565126@xxx Sun Nov 19 03:29:18 +0000 2017
X-GM-THRID: 1580974323849528573
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread