Received: by 10.223.164.202 with SMTP id h10csp1304847wrb; Fri, 17 Nov 2017 18:35:23 -0800 (PST) X-Google-Smtp-Source: AGs4zMbJ1F1rPvDTOljztizh02QpfpVFT7LF6qmd38CDKFFLNt5Ac8hovdPBJpXcd0UeufMXP1OQ X-Received: by 10.159.218.66 with SMTP id x2mr5184706plv.326.1510972523446; Fri, 17 Nov 2017 18:35:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510972523; cv=none; d=google.com; s=arc-20160816; b=s7gISOCGwn1HAOIv6HHBbI9NZVJc9vaKZJIkoThYHWaZu6vMzyFkASArh/7tEjxYda BnBlP+oM6kb6or2QUUaGTee5pw1Nh08/Hj2L1Ike+rgl4EWVo2Pi3phBlPupGMz3VgjY n4F79hRS11OWumq4tLZmtsg49Y1AyCPylwCWZ3zfqcg2hvqif0fdBu25tc6jiIipivwm 62yv+PdNPkgpUj3PBBzjQ4RvsnKVgy0oaaGZoHuV6k2c8e6ZcbWdBpkmKTrF7/Xio6nH D0IBAzFo8WtKlDGMqJcZLiWBNVCKwZN/Eg9Yfmd0Oe4hzxSbqhfMnmNmCJPmV8qQRkoV J5tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=rKhbnRiZ1dSqfXgbUpKOcnTx4iXs3Vq3R1q94+a/jfc=; b=mjSN30ZjiBtN6775AUIdcM16wd8usa6o+IjvsHRbbU6LFyU3evCFWXvp1NDUQhSWKM 9BFj33fvNkVjZDhgneMtoowxJVzc73VctgursqSjQ3fLZMSQy2yD6kyeH6PmTCPk7zKB SRIuBZqR6gTVWt08lpUf5yPtCzRSVsPoloPsgXmbGl/2Udq0uItGokGYsP7djWmSKb1C XkPV/H8xB9ZeEm/T5kNBvYIyuHiHqN8eHhLTGUfPBs80HzEAPviOSzX9ogIHr5ddHmkB N/EQsYV5reiVnoRy6YVg0Nsd6MaxNxhIoU6Qyf37ptZ3qpCq2dBFUom+ThOZMQccWjvD Da5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rvC+D8ZA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 136si3718206pgc.243.2017.11.17.18.35.10; Fri, 17 Nov 2017 18:35:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rvC+D8ZA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934655AbdKQTd4 (ORCPT + 93 others); Fri, 17 Nov 2017 14:33:56 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:43268 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933797AbdKQTdn (ORCPT ); Fri, 17 Nov 2017 14:33:43 -0500 Received: by mail-pf0-f195.google.com with SMTP id b6so2617927pff.10 for ; Fri, 17 Nov 2017 11:33:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=rKhbnRiZ1dSqfXgbUpKOcnTx4iXs3Vq3R1q94+a/jfc=; b=rvC+D8ZAPcbVIJ60iN6QKS0Cx5GO2Ds+nX9kYaAPG/uQN7yvIqBwAEnOY1wekpwV+Y JVA2jGE6gevqpjLGdPWp46GuyCDJNQvAHtTZhmo8Vsk60El0LJy7D8v8d2Xzm/rSlsaj vK0rXSRQw7dSrweEerb5Uxk0AAcHHcVxpsonOpLvVekRq68ymnEBvi2cxMx17K26BUXf Kit61EmOgXiCSEYRmgT6+MMdq5GOgYYjelx6eDqZh/jdCIXgAzLSNl8KZfo8+HVQLPs/ +9qSlS83BCjAs6RwRiByvMOjzCtcGlE6S4b+JF0Do9akFjY5mUAywlXBecykgW3GO0zI EChg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=rKhbnRiZ1dSqfXgbUpKOcnTx4iXs3Vq3R1q94+a/jfc=; b=CkGxQwRiaU3Tpx97NH+ckw1vI1JiOZ4O//dPv+3pqkExXk402jxmrNKIzyTCvVXqWL aUxJXxt6JPLat5rDA0Rj+jtyUSDb91GG5ozJ0E0AQ9AjiFdMI8ZW1s0/+FQjg1laHBNt pSNjPLNdv/Q9y549IraZuZpoQI+g9ACzOwINA6VZWkw9qLJVLrh/lu64NBW30uZ9YVBz 1y3r7bkzPExfp21dPiIUrzldD+S5X9wWjHBO+2Qqcw6yUptUqcob9WB3wcw32jDHB+z+ ZMYclISGy2vEkdU+cgZteEz66D3vwLMfOJJ8kSL4KkBaso+Td18mNQyYh/19TPHTOxEf TfeQ== X-Gm-Message-State: AJaThX6H6v8I9djvZX7qzT7zrlM9mVbhhH241sJVS+oUWEpEyq1RZ6BD JVrFRfF5UcoMBQfk+vdzGYU= X-Received: by 10.101.78.138 with SMTP id b10mr6013279pgs.36.1510947222880; Fri, 17 Nov 2017 11:33:42 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id u77sm9066799pfd.168.2017.11.17.11.33.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 17 Nov 2017 11:33:42 -0800 (PST) From: Arvind Yadav To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, matthias.bgg@gmail.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH 1/5] ASoC: ep93xx-ac97: Fix platform_get_irq's error checking Date: Sat, 18 Nov 2017 01:03:24 +0530 Message-Id: <1510947208-17134-2-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1510947208-17134-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1510947208-17134-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- sound/soc/cirrus/ep93xx-ac97.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/cirrus/ep93xx-ac97.c b/sound/soc/cirrus/ep93xx-ac97.c index bbf7a92..d66c561 100644 --- a/sound/soc/cirrus/ep93xx-ac97.c +++ b/sound/soc/cirrus/ep93xx-ac97.c @@ -378,8 +378,8 @@ static int ep93xx_ac97_probe(struct platform_device *pdev) return PTR_ERR(info->regs); irq = platform_get_irq(pdev, 0); - if (!irq) - return -ENODEV; + if (irq < 0) + return irq; ret = devm_request_irq(&pdev->dev, irq, ep93xx_ac97_interrupt, IRQF_TRIGGER_HIGH, pdev->name, info); -- 2.7.4 From 1584465437866513980@xxx Sun Nov 19 03:59:53 +0000 2017 X-GM-THRID: 1584342085865135600 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread