Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20171117141720.GB17880@kroah.com>
References: <20171117141720.GB17880@kroah.com>
From:   Philippe Ombredanne <pombredanne@nexb.com>
Date:   Fri, 17 Nov 2017 15:51:31 +0100
Message-ID: <CAOFm3uG9QVCTEvV-_pjBGgKoHOWi6ps2tp=NABuHinOQi+QeTw@mail.gmail.com>
Subject: Re: [PATCH] input: remove unneeded DRIVER_LICENSE #defines
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Arvind Yadav <arvind.yadav.cs@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>, linux-input@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Nov 17, 2017 at 3:17 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> There is no need to #define the license of the driver, just put it in
> the MODULE_LICENSE() line directly as a text string.
>
> This allows tools that check that the module license matches the source
> code license to work properly, as there is no need to unwind the
> unneeded dereference.  For some of these drivers, the #define is just a
> few lines above the MODULE_LICENSE() line, which is extra pointless.
>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>
> Reported-by: Philippe Ombredanne <pombredanne@nexb.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
-- 
Cordially
Philippe Ombredanne

From 1584437632578373942@xxx Sat Nov 18 20:37:56 +0000 2017
X-GM-THRID: 1584169667655788003
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread