Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Arvind Yadav <arvind.yadav.cs@gmail.com>
To:     dmitry.torokhov@gmail.com, maxime.ripard@free-electrons.com,
        wens@csie.org, linux@roeck-us.net, wsa@the-dreams.de,
        daniel.thompson@linaro.org, mcuos.com@gmail.com
Cc:     linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/10] Input: serio: Fix platform_get_irq's error checking
Date:   Sat, 18 Nov 2017 00:45:26 +0530
Message-Id: <1510946132-13554-5-git-send-email-arvind.yadav.cs@gmail.com>
In-Reply-To: <1510946132-13554-1-git-send-email-arvind.yadav.cs@gmail.com>
References: <1510946132-13554-1-git-send-email-arvind.yadav.cs@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/input/serio/sun4i-ps2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/serio/sun4i-ps2.c b/drivers/input/serio/sun4i-ps2.c
index 04b96fe..405c82f 100644
--- a/drivers/input/serio/sun4i-ps2.c
+++ b/drivers/input/serio/sun4i-ps2.c
@@ -264,7 +264,7 @@ static int sun4i_ps2_probe(struct platform_device *pdev)
 
 	/* Get IRQ for the device */
 	irq = platform_get_irq(pdev, 0);
-	if (!irq) {
+	if (irq < 0) {
 		dev_err(dev, "no IRQ found\n");
 		error = -ENXIO;
 		goto err_disable_clk;
-- 
2.7.4


From 1584394807100971388@xxx Sat Nov 18 09:17:14 +0000 2017
X-GM-THRID: 1584394807100971388
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread