Received: by 10.223.164.202 with SMTP id h10csp1129314wrb; Fri, 17 Nov 2017 14:30:12 -0800 (PST) X-Google-Smtp-Source: AGs4zMa/jCUwWbROAQ9FP+Jr42oq8UrgGv4yyncdZzIwTJsIHebPWf01IFYmbj4b99vlotmoXBRl X-Received: by 10.98.160.193 with SMTP id p62mr3582617pfl.138.1510957812660; Fri, 17 Nov 2017 14:30:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510957812; cv=none; d=google.com; s=arc-20160816; b=0llejtl3w2ebhV5Ub+FDLDbYGbHWlhzJL3joE9ydZlwV9Mf3qlMh5Dmi33bCDBAe3l TDzm+Z/HUzPrZ09oFT69LbRIMZ0MnbuZlb8bRJWkpscZ2ZTOezYy0gsilfPRz7WYGvM+ XSGRJo0VAOvYsCZKUI/ze3P1KK8bcs3ZliyLYC742tuMbHHFYUv2EOuix7hwXyRRXSzL vRjGF02bhyhsauBdHEXl3uE7Bpmq/yJK+ang54RppZ6MP1W1RYX9He1UhsD8aMDQtqsC IbQkPqcgWOQUK1bSELOeaUdRahRNDkWY8K95GQdIX5x67XgJi+Z6FSRX6SLO7DtfOJ8M 452g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=5T4/hzC+6aGkjr4XeuFW/W2TK5vfq4WwXA76mwHPR8A=; b=i1N68BvzRsc7yImHMGGPnTG0tRosgyAgdpi9MwD3QRjRMSfGeLxD8ui9ZSyS6HqRAb a1ehjjboWyceTubGYbmjkLG4mXVxM5hVbw6u1NKtncWxx+y0j5EbL5pFdJJ8NoTOBGFt nGltwidzSnPW/YPnYaJzXXa9TU/5dL7Ga7otb8mueNhLQcwBNC6Kfd52pRmOTCFUTeSs C2sBHk9/6jvoQ13vO9Qw3NYBznTWRa2jxz643kM5oVyO9yJbI/X+yOXroyuFCXVcSzbs uwW8Y1JbSgv0QzYfWqlJvmVDuQA9Uu6h3wcpMwMWuMKWfMYVMmSXfxk1I6TFNw9H41PI 4rJw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i69si3871559pfd.147.2017.11.17.14.29.59; Fri, 17 Nov 2017 14:30:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935234AbdKQPBK (ORCPT + 93 others); Fri, 17 Nov 2017 10:01:10 -0500 Received: from bastet.se.axis.com ([195.60.68.11]:42442 "EHLO bastet.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934305AbdKQPAv (ORCPT ); Fri, 17 Nov 2017 10:00:51 -0500 Received: from localhost (localhost [127.0.0.1]) by bastet.se.axis.com (Postfix) with ESMTP id 30E8E185BF; Fri, 17 Nov 2017 16:00:50 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at bastet.se.axis.com Received: from bastet.se.axis.com ([IPv6:::ffff:127.0.0.1]) by localhost (bastet.se.axis.com [::ffff:127.0.0.1]) (amavisd-new, port 10024) with LMTP id QqFZsYx02CC8; Fri, 17 Nov 2017 16:00:47 +0100 (CET) Received: from boulder02.se.axis.com (boulder02.se.axis.com [10.0.8.16]) by bastet.se.axis.com (Postfix) with ESMTPS id 9F950185DE; Fri, 17 Nov 2017 16:00:47 +0100 (CET) Received: from boulder02.se.axis.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 89CCF1A099; Fri, 17 Nov 2017 16:00:47 +0100 (CET) Received: from boulder02.se.axis.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7DE811A069; Fri, 17 Nov 2017 16:00:47 +0100 (CET) Received: from thoth.se.axis.com (unknown [10.0.2.173]) by boulder02.se.axis.com (Postfix) with ESMTP; Fri, 17 Nov 2017 16:00:47 +0100 (CET) Received: from lnxartpec1.se.axis.com (lnxartpec1.se.axis.com [10.88.4.10]) by thoth.se.axis.com (Postfix) with ESMTP id 71CEF112F; Fri, 17 Nov 2017 16:00:47 +0100 (CET) Received: by lnxartpec1.se.axis.com (Postfix, from userid 20283) id 6BFBD400FC; Fri, 17 Nov 2017 16:00:47 +0100 (CET) From: Niklas Cassel To: Kishon Vijay Abraham I , Lorenzo Pieralisi , Bjorn Helgaas Cc: Niklas Cassel , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] PCI: endpoint: Fix find_first_zero_bit() usage Date: Fri, 17 Nov 2017 16:00:41 +0100 Message-Id: <20171117150041.30509-3-niklas.cassel@axis.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20171117150041.30509-1-niklas.cassel@axis.com> References: <20171117150041.30509-1-niklas.cassel@axis.com> X-TM-AS-GCONF: 00 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org find_first_zero_bit()'s parameter 'size' is defined in bits, not in bytes. Calling find_first_zero_bit() with the wrong size unit will lead to insidious bugs. Fix this by using replacing find_first_zero_bit() with ffz(), since ffz() only works on a single 'unsigned long' and therefore does not need a size argument. Fixes: d74679911610 ("PCI: endpoint: Introduce configfs entry for configuring EP functions") Signed-off-by: Niklas Cassel --- drivers/pci/endpoint/pci-ep-cfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/pci/endpoint/pci-ep-cfs.c b/drivers/pci/endpoint/pci-ep-cfs.c index 4f74386c1ced..96b984685640 100644 --- a/drivers/pci/endpoint/pci-ep-cfs.c +++ b/drivers/pci/endpoint/pci-ep-cfs.c @@ -108,8 +108,7 @@ static int pci_epc_epf_link(struct config_item *epc_item, if (ret) goto err_add_epf; - func_no = find_first_zero_bit(&epc_group->function_num_map, - sizeof(epc_group->function_num_map)); + func_no = ffz(epc_group->function_num_map); set_bit(func_no, &epc_group->function_num_map); epf->func_no = func_no; -- 2.14.2 From 1584366043849251759@xxx Sat Nov 18 01:40:03 +0000 2017 X-GM-THRID: 1584366043849251759 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread