Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755864AbYANKY3 (ORCPT ); Mon, 14 Jan 2008 05:24:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754439AbYANKYD (ORCPT ); Mon, 14 Jan 2008 05:24:03 -0500 Received: from [212.12.190.40] ([212.12.190.40]:48277 "EHLO raad.intranet" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753432AbYANKYA (ORCPT ); Mon, 14 Jan 2008 05:24:00 -0500 From: Al Boldi To: Stefan Richter , Greg KH Subject: Re: [PATCH 0/5] USB Kconfig: Reorganize USB Kconfig Menu Date: Mon, 14 Jan 2008 13:21:51 +0300 User-Agent: KMail/1.5 Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, David Brownell , Andrew Morton References: <200801051546.SAA08937@raad.intranet> <20080112195333.GA4924@kroah.com> <4789FAF8.8080107@s5r6.in-berlin.de> In-Reply-To: <4789FAF8.8080107@s5r6.in-berlin.de> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200801141321.51185.a1426z@gawab.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2303 Lines: 66 Stefan Richter wrote: > Greg KH wrote: > > On Sat, Jan 12, 2008 at 01:20:46PM +0300, Al Boldi wrote: > >> Greg KH wrote: > >>> On Sat, Jan 05, 2008 at 06:40:38PM +0300, Al Boldi wrote: > >>>> Reorganize USB Kconfig Menu, and move USB_GADGET out into the Device > >>>> Driver Menu. ?This helps the USB Kconfig Menu to be more > >>>> logical/usable. > >>>> > >>>> Patchset against 2.6.23 > >>> > >>> So what was the final verdict in this patch set? > >> > >> IMHO, it's a lot better than what we have right now, and it's split up > >> so that you can pick and choose what you think is useful. > >> > >>> Can you rsend this against 2.6.24-rc7 with the requested changes (if > >>> any) in it? > >> > >> The only critical change is in patch 2/5: > >> > >> menuconfig USB_STORAGE > >> tristate "USB Mass Storage support" > >> - depends on USB && SCSI > >> + depends on USB && BLOCK > >> + select SCSI > >> > >> > >> I was hoping you could take care of it, or maybe wait until 2.6.25 is > >> out. > > > > Well, if you want such a change to go into 2.6.25, I need the patches > > now :) > > > > So, can you respin these against 2.6.24-rc7, with the above fix, so that > > I can apply them and test them out? > > May I repeat my request that nobody does "select SCSI", please? > > Al Boldy, would you please explain like I asked you: > - what is wrong with the current solution which tells the user to > first enable SCSI to get the USB_STORAGE option, > - whether there are frequent end-user requests which demonstrate > that many people currently don't realize how to enable USB_STORAGE. > > Please use "select" carefully, particularly *only* for options which > enable simple compact library-like code which > - is small, > - doesn't itself depend on anything, > - doesn't has further configuration options in some other menu. > None of this applies to CONFIG_SCSI. I thought we discussed this before. We do it here, for the same reasons libata does it. In any case, the patch is optional. Thanks! -- Al -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/