Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset
 with 'do_flr' SysFS attribute
To:     Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        Jan Beulich <JBeulich@suse.com>
Cc:     Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        linux-kernel@vger.kernel.org
References: <20171106174842.20276-1-Govinda.Tatti@Oracle.COM>
 <5A01D3F3020000780018CE86@prv-mh.provo.novell.com>
 <8940b38d-715c-9fcb-cc74-46574d416703@oracle.com>
 <5A041FB9020000780018D6E8@prv-mh.provo.novell.com>
 <af25e0d8-ca55-7eb4-649e-5297b0e09299@oracle.com>
 <5A1EE1D50200007800193318@prv-mh.provo.novell.com>
 <20171129162907.GO31092@char.us.oracle.com>
 <5A1EF1040200007800193425@prv-mh.provo.novell.com>
 <20171129192630.GS31092@char.us.oracle.com>
From:   Govinda Tatti <govinda.tatti@oracle.com>
Organization: Oracle Corporation
Message-ID: <b6698aef-c6f4-0a94-ae2f-b95f1643924d@oracle.com>
Date:   Wed, 29 Nov 2017 13:44:43 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <20171129192630.GS31092@char.us.oracle.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thanks Konrad for your response. Please see below for my comments.

>>>> Well, that's more a question to Konrad as the maintainer.
>>>> Personally I'd prefer just "reset", as "pci" is redundant and "bus"
>>> Can't do 'reset'.
>> Why?
> B/c I forgot that this attribute is not per device, but on the module sub-directory:
>
> /sys/bus/pci/drivers/pciback/do_flr
>
> It can be indeed called 'reset'.

Good.  We will rename sysfs attribute from "do_flr" to "reset"

>>>> doesn't cover the slot variant.
>>> 'bus_reset' sounds lovely?
>> Lovely sounding or not, it may end up misleading, and even more so
>> if - like asked for - FLR would be tried first.
> Fair enough. Reset should work then.
So, we will use the following sequence to reset the requested 
device/function.

- FLR (as first option)
- BUS/SLOT reset (as fall-back option) if FLR is not supported or any 
issue with FLR

Cheers
GOVINDA

From 1585429891876838542@xxx Wed Nov 29 19:29:28 +0000 2017
X-GM-THRID: 1583346318922306893
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread