Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset
 with 'do_flr' SysFS attribute
To:     Juergen Gross <jgross@suse.com>,
        =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc:     xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com,
        linux-kernel@vger.kernel.org, konrad.wilk@oracle.com
References: <20171106174842.20276-1-Govinda.Tatti@Oracle.COM>
 <20171107112123.t6w4v5irbjysmyhe@dhcp-3-128.uk.xensource.com>
 <bff30bc1-a4cd-3ddd-4335-df0d0cc75244@oracle.com>
 <54bdfc56-891f-5c78-77c1-29758f8220f4@suse.com>
From:   Govinda Tatti <govinda.tatti@oracle.com>
Organization: Oracle Corporation
Message-ID: <aca6237f-f430-a06d-e4b1-9a11661f3502@oracle.com>
Date:   Wed, 8 Nov 2017 09:34:54 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <54bdfc56-891f-5c78-77c1-29758f8220f4@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 11/8/2017 9:09 AM, Juergen Gross wrote:
> On 08/11/17 16:00, Govinda Tatti wrote:
>> Thanks Roger for your review comments. Please see below for my comments.
>>
>> On 11/7/2017 5:21 AM, Roger Pau Monné wrote:
>>> On Mon, Nov 06, 2017 at 12:48:42PM -0500, Govinda Tatti wrote:
>>>> +out:
>>>> +    if (!err)
>>>> +        err = count;
>>>> +
>>>> +    return err;
>>> What's the purpose of returning count here?
>> Not sure. Will check with Konrad and address this comment.
> You are telling sysfs that you have consumed all input characters.
>
Thanks Juergen

Cheers
GOVINDA

From 1583511091145646305@xxx Wed Nov 08 15:10:57 +0000 2017
X-GM-THRID: 1583346318922306893
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread