From: Florian Fainelli <florian.fainelli@telecomint.eu>
To: Marc Pignat <marc.pignat@hevs.ch>
Subject: Re: [RFC, PATCH, take 2] watchdog on generic gpio
Date: Mon, 14 Jan 2008 12:06:38 +0100
User-Agent: KMail/1.9.7
Cc: wim@iguana.be, linux-kernel@vger.kernel.org,
       "Alan Cox" <alan@lxorguk.ukuu.org.uk>,
       "Mike Frysinger" <vapier.adi@gmail.com>
References: <200801141103.23744.marc.pignat@hevs.ch>
In-Reply-To: <200801141103.23744.marc.pignat@hevs.ch>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Message-Id: <200801141206.39858.florian.fainelli@telecomint.eu>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 910
Lines: 26

Hi Marc,

Le lundi 14 janvier 2008, Marc Pignat a ?crit?:
> +static int gpio_wdt_keepalive(struct gpio_wdt *wdt)
> +{
> +	gpio_set_value(wdt->pdata->pin, 0);
> +	gpio_set_value(wdt->pdata->pin, 1);
> +	return 0;
> +}

I would like this function to be supplied by the platform_data structure 
because as I mentioned before, not all GPIO connected watchdog will simply 
need a single bit to be toggled, but also sometimes a full GPIO line.

If we do not supply any specific callback to keepalive the watchdog let's just 
assume we need a single bit to be toggled if this is ok with you ?

Thank you !
-- 
Cordialement, Florian Fainelli
------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/