Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20171115010629.32859-1-tkjos@google.com>
References: <20171115010629.32859-1-tkjos@google.com>
From:   Todd Kjos <tkjos@android.com>
Date:   Thu, 16 Nov 2017 09:48:13 -0800
Message-ID: <CAD0t5oMftBTyRqTVpCNjFoVzfpouiztPHtcK_rLpE_1kNvtWZw@mail.gmail.com>
Subject: Re: [PATCH] binder: fix proc->files use-after-free
To:     Todd Kjos <tkjos@google.com>, Greg KH <gregkh@linuxfoundation.org>,
        "Arve Hj??nnev??g" <arve@android.com>, devel@driverdev.osuosl.org,
        LKML <linux-kernel@vger.kernel.org>,
        Martijn Coenen <maco@google.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> @@ -875,22 +871,34 @@ static void binder_free_thread(struct binder_thread *thread);
>  static void binder_free_proc(struct binder_proc *proc);
>  static void binder_inc_node_tmpref_ilocked(struct binder_node *node);
>
> +struct files_struct *binder_get_files_struct(struct binder_proc *proc)

This should be declared static:
  static struct files_struct *binder_get_files_struct(struct binder_proc *proc)

Greg- should I send a "v2" for this?

> +{
> +       return get_files_struct(proc->tsk);
> +}
> +

From 1584246545423727391@xxx Thu Nov 16 18:00:41 +0000 2017
X-GM-THRID: 1584096400353009036
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread