Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 16 Nov 2017 18:52:57 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Todd Kjos <tkjos@android.com>
Cc:     Todd Kjos <tkjos@google.com>, Arve Hj??nnev??g <arve@android.com>,
        devel@driverdev.osuosl.org, LKML <linux-kernel@vger.kernel.org>,
        Martijn Coenen <maco@google.com>
Subject: Re: [PATCH] binder: fix proc->files use-after-free
Message-ID: <20171116175257.GA30594@kroah.com>
References: <20171115010629.32859-1-tkjos@google.com>
 <CAD0t5oMftBTyRqTVpCNjFoVzfpouiztPHtcK_rLpE_1kNvtWZw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAD0t5oMftBTyRqTVpCNjFoVzfpouiztPHtcK_rLpE_1kNvtWZw@mail.gmail.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Nov 16, 2017 at 09:48:13AM -0800, Todd Kjos wrote:
> > @@ -875,22 +871,34 @@ static void binder_free_thread(struct binder_thread *thread);
> >  static void binder_free_proc(struct binder_proc *proc);
> >  static void binder_inc_node_tmpref_ilocked(struct binder_node *node);
> >
> > +struct files_struct *binder_get_files_struct(struct binder_proc *proc)
> 
> This should be declared static:
>   static struct files_struct *binder_get_files_struct(struct binder_proc *proc)
> 
> Greg- should I send a "v2" for this?

Please do, I can't do anything with these until after 4.15-rc1 is out,
so you have time to do it :)

thanks,

greg k-h

From 1584096400353009036@xxx Wed Nov 15 02:14:11 +0000 2017
X-GM-THRID: 1584096400353009036
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread