Message-Id: <478B0B7C.BA47.005A.0@novell.com>
Date: Mon, 14 Jan 2008 07:13:00 -0500
From: "Gregory Haskins" <ghaskins@novell.com>
To: "Mike Galbraith" <efault@gmx.de>, "Steven Rostedt" <rostedt@goodmis.org>
Cc: "Ingo Molnar" <mingo@elte.hu>, "Thomas Gleixner" <tglx@linutronix.de>,
       "Mariusz Kozlowski" <m.kozlowski@tuxland.pl>,
       "LKML" <linux-kernel@vger.kernel.org>,
       "RT" <linux-rt-users@vger.kernel.org>
Subject: Re: 2.6.24-rc7-rt1
References: <1200250801.9190.7.camel@localhost.localdomain>
 <200801132143.34889.m.kozlowski@tuxland.pl>
 <Pine.LNX.4.58.0801131552350.10093@gandalf.stny.rr.com>
 <1200299260.4665.17.camel@homer.simson.net>
In-Reply-To: <1200299260.4665.17.camel@homer.simson.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2386
Lines: 68

>>> On Mon, Jan 14, 2008 at  3:27 AM, in message
<1200299260.4665.17.camel@homer.simson.net>, Mike Galbraith <efault@gmx.de>
wrote: 

> On Sun, 2008-01-13 at 15:54 -0500, Steven Rostedt wrote:
> 
>> OK, -rt2 will take a bit more beating from me before I release it, so it
>> might take some time to get it out (expect it out on Monday).
> 
> Ah, that reminds me (tests, yup) I still need the patchlet below to
> resume from ram without black screen of death.

I had forgotten about this issue over the holidays...Sorry Mike.

So does that BUG_ON trip if you remove the first hunk?

> No idea why my P4 box
> seems to be the only box in the rt galaxy affected.  (haven't poked at
> it since the holidays)
> 
> Index: linux-2.6.24.git-rt1/kernel/sched_rt.c
> ===================================================================
> --- linux-2.6.24.git-rt1.orig/kernel/sched_rt.c
> +++ linux-2.6.24.git-rt1/kernel/sched_rt.c
> @@ -33,6 +33,9 @@ static inline void rt_clear_overload(str
>  
>  static void update_rt_migration(struct rq *rq)
>  {
> +	if (unlikely(num_online_cpus() == 1))
> +		return;
> +
>  	if (rq->rt.rt_nr_migratory && (rq->rt.rt_nr_running > 1)) {
>  		if (!rq->rt.overloaded) {
>  			rt_set_overload(rq);
> @@ -105,8 +108,10 @@ static inline void dec_rt_tasks(struct t
>  		} /* otherwise leave rq->highest prio alone */
>  	} else
>  		rq->rt.highest_prio = MAX_RT_PRIO;
> -	if (p->nr_cpus_allowed > 1)
> +	if (p->nr_cpus_allowed > 1) {
> +		BUG_ON(!rq->rt.rt_nr_migratory);
>  		rq->rt.rt_nr_migratory--;
> +	}
>  
>  	if (rq->rt.highest_prio != highest_prio)
>  		cpupri_set(&rq->rd->cpupri, rq->cpu, rq->rt.highest_prio);
> 
> 
> btw, CONFIG_INTEL_IOATDMA compile booboo
> 
>   CC      drivers/dma/ioat_dma.o
> drivers/dma/ioat_dma.c: In function ‘ioat1_tx_submit’:
> drivers/dma/ioat_dma.c:300: error: too few arguments to function 
> ‘__list_splice’
> make[2]: *** [drivers/dma/ioat_dma.o] Error 1
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/