Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2] mm: filemap: remove include of hardirq.h
To:     mhocko@kernel.org, akpm@linux-foundation.org, willy@infradead.org
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <1509985319-38633-1-git-send-email-yang.s@alibaba-inc.com>
From:   "Yang Shi" <yang.s@alibaba-inc.com>
Message-ID: <43348133-9c30-4c4f-8bc9-498841a01bd6@alibaba-inc.com>
Date:   Sat, 18 Nov 2017 01:58:15 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <1509985319-38633-1-git-send-email-yang.s@alibaba-inc.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi folks,

Any comment on this patch? The quick build test passed on the latest 
Linus's tree.

Thanks,
Yang


On 11/6/17 8:21 AM, Yang Shi wrote:
> in_atomic() has been moved to include/linux/preempt.h, and the filemap.c
> doesn't use in_atomic() directly at all, so it sounds unnecessary to
> include hardirq.h.
> 
> Signed-off-by: Yang Shi <yang.s@alibaba-inc.com>
> ---
> v1 --> v2:
> * Removed the wrong message about kernel size change
> 
>   mm/filemap.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/mm/filemap.c b/mm/filemap.c
> index 594d73f..57238f4 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -31,7 +31,6 @@
>   #include <linux/blkdev.h>
>   #include <linux/security.h>
>   #include <linux/cpuset.h>
> -#include <linux/hardirq.h> /* for BUG_ON(!in_atomic()) only */
>   #include <linux/hugetlb.h>
>   #include <linux/memcontrol.h>
>   #include <linux/cleancache.h>
> 

From 1583334790393356885@xxx Mon Nov 06 16:28:43 +0000 2017
X-GM-THRID: 1583071819350852518
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread