Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] mm: filemap: remove include of hardirq.h
To:     Matthew Wilcox <willy@infradead.org>
Cc:     mhocko@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <1509734868-120762-1-git-send-email-yang.s@alibaba-inc.com>
 <20171104134709.GA23784@bombadil.infradead.org>
From:   "Yang Shi" <yang.s@alibaba-inc.com>
Message-ID: <e2253597-cb34-409e-9be0-768136ca0942@alibaba-inc.com>
Date:   Tue, 07 Nov 2017 00:06:11 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20171104134709.GA23784@bombadil.infradead.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 11/4/17 6:47 AM, Matthew Wilcox wrote:
> On Sat, Nov 04, 2017 at 02:47:48AM +0800, Yang Shi wrote:
>> in_atomic() has been moved to include/linux/preempt.h, and the filemap.c
>> doesn't use in_atomic() directly at all, so it sounds unnecessary to
>> include hardirq.h.
>> With removing hardirq.h, around 32 bytes can be saved for x86_64 bzImage
>> with allnoconfig.
> 
> Wait, what?  How would including an unused header file increase the size
> of the final image?

Sorry for the wrong message, I double checked again with building kernel 
a couple of times then comparing the size, there is no change. Will 
remove this from the commit log.

Yang

> 

From 1583143488457993753@xxx Sat Nov 04 13:48:04 +0000 2017
X-GM-THRID: 1583071819350852518
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread