Received: by 10.223.164.202 with SMTP id h10csp669681wrb; Wed, 15 Nov 2017 06:10:09 -0800 (PST) X-Google-Smtp-Source: AGs4zMbtrdEyPYK8X8Ed8cRkVBt/ca2o1gsZTNn/W9FrjiVSC4lxhywRumNLi4Eg5LUIxrpJoVA2 X-Received: by 10.84.218.204 with SMTP id g12mr16012495plm.213.1510755009324; Wed, 15 Nov 2017 06:10:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510755009; cv=none; d=google.com; s=arc-20160816; b=DTctC0I3A5YSRUG+Rr9O995oXwG2PIb9pfLCyxZsyxvYDRUsY48IIiRC1g49bVXa8q hyBJATwUaGhoX0F719oNKgJtDzz3fWdyGlBjtjqGhjEtmMPREkMeFwkMm8mzkgehYDcX z9Cw5cFMlFxCG7f8S6UkDoWRA623ib8XYeuIHO4KUKTZI1N50A/otCxCuRbPMcK+6nNv uAuNaPMJJzwwfdP+5sgmPxrkJvj6PO6Y5fx552hNeEuMX7b2C9QR6EK55P7V57F1YmDc yCq55kW8jIHDpCeTXbOF0PvWjpi0s3Ieb8rPcMWgEOtMUE850/3mU/6bOkcF6mJ/AW73 vV6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:arc-authentication-results; bh=asfq16uaWqq/JNCEtAJv6xdNFOnj3XS7fcY/lDTKZXo=; b=I9SdPk8Bn2EtRPGsWwga7Lbn5M2tlRsoztc6vBWMsxZbRiWbuDjps1urLdf4fTM18I e8q5Tw2bq/JGQbbRIQZOh1hPrPfjTpHdMQh9PNX50GuxAOUwPkHLEyjCUOGYv75ntSb+ ppGMvc7WzrmqXNwMKTQgOwE9ep4N1IqGedp8na8el5Vfown5nPIclsJ6tq6hyiJGLua0 Up2rBJ7quTFqWZksJepIUvFpEMnEp3pweG7Z0qK/hesV9KsgtD6uRJkevtA6vkkrC+tK hrKCMv9IYLLoZBqt9REH5zL0QBOTph48nwzAfdVnnm4vJKr9qlfQ51mt+xEAjxlPeBIH T2hw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 71si7432830pfk.250.2017.11.15.06.09.56; Wed, 15 Nov 2017 06:10:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932614AbdKONJS (ORCPT + 90 others); Wed, 15 Nov 2017 08:09:18 -0500 Received: from esa1.microchip.iphmx.com ([68.232.147.91]:60131 "EHLO esa1.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932361AbdKONJC (ORCPT ); Wed, 15 Nov 2017 08:09:02 -0500 X-IronPort-AV: E=Sophos;i="5.44,399,1505804400"; d="scan'208";a="9340247" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 15 Nov 2017 06:09:01 -0700 Received: from eh-station.mchp-main.com (10.10.76.4) by chn-sv-exch07.mchp-main.com (10.10.76.108) with Microsoft SMTP Server id 14.3.352.0; Wed, 15 Nov 2017 06:09:00 -0700 From: Eugen Hristev To: , , , , , , , , CC: Subject: [PATCH v3 4/4] iio: adc: at91-sama5d2_adc: ack DRDY irq in direct mode Date: Wed, 15 Nov 2017 14:56:48 +0200 Message-ID: <1510750608-8697-5-git-send-email-eugen.hristev@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1510750608-8697-1-git-send-email-eugen.hristev@microchip.com> References: <1510750608-8697-1-git-send-email-eugen.hristev@microchip.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Need to acknowledge DRDY irq in direct mode/ software triggered mode. Otherwise, on the next conversion, overrun flag will be raised, which is not a correct state. This doesn't affect the functionality, but will generate possible incorrect overrun reports. Signed-off-by: Eugen Hristev --- drivers/iio/adc/at91-sama5d2_adc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c index 11d34a8..274cb5e 100644 --- a/drivers/iio/adc/at91-sama5d2_adc.c +++ b/drivers/iio/adc/at91-sama5d2_adc.c @@ -787,6 +787,9 @@ static int at91_adc_read_raw(struct iio_dev *indio_dev, at91_adc_writel(st, AT91_SAMA5D2_IDR, BIT(chan->channel)); at91_adc_writel(st, AT91_SAMA5D2_CHDR, BIT(chan->channel)); + /* Needed to ACK the DRDY interruption */ + at91_adc_readl(st, AT91_SAMA5D2_LCDR); + mutex_unlock(&st->lock); iio_device_release_direct_mode(indio_dev); -- 2.7.4 From 1584366354894033573@xxx Sat Nov 18 01:45:00 +0000 2017 X-GM-THRID: 1584366354894033573 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread