From: Marc Pignat <marc.pignat@hevs.ch>
Organization: HEVs
To: Florian Fainelli <florian.fainelli@telecomint.eu>
Subject: Re: [RFC, PATCH, take 2] watchdog on generic gpio
Date: Mon, 14 Jan 2008 14:01:33 +0100
User-Agent: KMail/1.9.7
Cc: linux-kernel@vger.kernel.org
References: <200801141103.23744.marc.pignat@hevs.ch> <200801141206.39858.florian.fainelli@telecomint.eu>
In-Reply-To: <200801141206.39858.florian.fainelli@telecomint.eu>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200801141401.33783.marc.pignat@hevs.ch>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1554
Lines: 38

Hi Florian!

On Monday 14 January 2008, Florian Fainelli wrote:
...
> I would like this function to be supplied by the platform_data structure 
> because as I mentioned before, not all GPIO connected watchdog will simply 
> need a single bit to be toggled, but also sometimes a full GPIO line.
I understand your wish, but...
You told me that your plaform doesn't implement the generic gpio interface
(yet?), so this driver can't work for you.

...
> 
> If we do not supply any specific callback to keepalive the watchdog let's just 
> assume we need a single bit to be toggled if this is ok with you ?
This is not the only function to be changed, start, stop and keepalive (and
probably suspend/resume) should be changed, and when the 'Uniform Watchdog
Device Driver' will be merged, writing your driver dealing with more gpio will
be almost trivial.

Please make sure to look a the right place, the git tree for the unified
driver you have given is 17 month old... here is the latest:
http://git.kernel.org/?p=linux/kernel/git/wim/linux-2.6-watchdog-mm.git;a=summary

I'm trying to get this work merged because I use it, it works for me and I'm
almost sure I haven't got the only embedded system using a max823 connected
to a gpio.

Let me know if you want some help implementing your driver!

Regards

Marc
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/