Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Arvind Yadav <arvind.yadav.cs@gmail.com>
To:     f.fainelli@gmail.com
Cc:     linux-kernel@vger.kernel.org
Subject: [PATCH v2] vlynq : Handle return value of platform_get_irq_byname and vlynq_probe
Date:   Fri, 17 Nov 2017 22:33:25 +0530
Message-Id: <292644d8f55e267488e1e7362ec2cf4b6ea95d2f.1510937831.git.arvind.yadav.cs@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

platform_get_irq_byname() can fail here and we must check its return value.

device_register() can fail here, initialised 'result' variable
beforen'goto fail_register' otherwise vlynq_probe will return uninitialised
'result' variable.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
changes in v2 :
              return device_register() value insted of -ENXIO.

 drivers/vlynq/vlynq.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c
index c0227f9..a200ff0 100644
--- a/drivers/vlynq/vlynq.c
+++ b/drivers/vlynq/vlynq.c
@@ -722,13 +722,19 @@ static int vlynq_probe(struct platform_device *pdev)
 					    VLYNQ_REMOTE_OFFSET);
 
 	dev->irq = platform_get_irq_byname(pdev, "irq");
+	if (dev->irq < 0) {
+		result = dev->irq;
+		goto fail_register;
+	}
 	dev->irq_start = irq_res->start;
 	dev->irq_end = irq_res->end;
 	dev->local_irq = dev->irq_end - dev->irq_start;
 	dev->remote_irq = dev->local_irq - 1;
 
-	if (device_register(&dev->dev))
+	result = device_register(&dev->dev);
+	if (result)
 		goto fail_register;
+
 	platform_set_drvdata(pdev, dev);
 
 	printk(KERN_INFO "%s: regs 0x%p, irq %d, mem 0x%p\n",
-- 
2.7.4


From 1584466931646067747@xxx Sun Nov 19 04:23:37 +0000 2017
X-GM-THRID: 1584377582657647724
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread