Received: by 10.223.164.202 with SMTP id h10csp1382742wrb; Fri, 17 Nov 2017 20:43:41 -0800 (PST) X-Google-Smtp-Source: AGs4zMYT9gGoUDGTci2aCwLu5j1u/aF6J+V4093xcloD1OWeXz0COmWKnFyVdvaEKPjTb87gSzC2 X-Received: by 10.84.168.35 with SMTP id e32mr7429733plb.122.1510980220926; Fri, 17 Nov 2017 20:43:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510980220; cv=none; d=google.com; s=arc-20160816; b=RR2XcRNPPAW6cYPeG9rGIxNchrW9/xUg1DgQHEIRm1Ctyw1DZ3a5r1M2JeoqTi/Ca0 ka80rSy7ZKElTLrm9AQ3I1KHf14L/ZEll5GQm6Yfq91IUj9w3pkxHlBLnUp63ONNNp3m RdlOP+tzUfadWRQjZs9WWcS/Ea82lNKAPb84j63w/WCvkluWgVrJ9wjuG0FF+3tpSMWm rdNBZT3PlHYPjjAmw1bHQVq0qi1q58sUMB535WzvBcAGRlTd4HgsBEImz6J/fn8W6e2v a0cmrByqC9DZ9ULXOyoENp11QJDGVA+Tb8pUkSl5ikuRTmE0uWGh00H1i1JVFf8RsPEM G4JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=F7buBfDBa3xtYh+wXDsIuD708fLbtmglyRU6czhdO8I=; b=hHUelUJRCZlsUgP29AxyrhwXuRA4C42u8DQwBh9KLdATtJnyYcrO4G3SqvYo5bEAse VDDQtqI5B0E/wB9RnTVsN/vH23V5aGWEzw55SYkHC7NFMp4dmB0fOvDdz+FBAYgxr2tx tsuPKzTByJq0G2ro+6g1UCz99hJcldYFgOwyUl35Sy2mQDUe4KYHm+hvDbpJ70q0iSHF b0BaOzWFAAgUqATueKZKWakKTRiJb59AGXLx1ehg3l1lyYLtwWmGJi5XA66qLXYgIzzZ ARnYuyzrWUIblu/FYgyFSUgtwrMKJ/WYKE/quHQMy6rHQfM2bWgGRhipkGGM2Ey25yvD EaSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=slztnJRq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e15si3837145pgr.15.2017.11.17.20.43.28; Fri, 17 Nov 2017 20:43:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=slztnJRq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965777AbdKQUGP (ORCPT + 93 others); Fri, 17 Nov 2017 15:06:15 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:37732 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751061AbdKQUGB (ORCPT ); Fri, 17 Nov 2017 15:06:01 -0500 Received: by mail-wm0-f67.google.com with SMTP id v186so8583787wma.2; Fri, 17 Nov 2017 12:06:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=F7buBfDBa3xtYh+wXDsIuD708fLbtmglyRU6czhdO8I=; b=slztnJRqYrLWkQVFzmlxsGlxff3xdkHFNeawkJGI3T3W5MadipqGNaoavajjPUD1+i fmTP37u3WGpaYCcQBaU7vMxFUZ/ANiKhaoE82BcNzVQg9s1EGBtq1V8PG5oxrd/8GC6U lCgcEWGHprz58o7vecntVuOiabRCoFDTs6jgVT5z8+iQF49zeWpPs0s0Jh6N7N8ZsKQL kmE6HZ99tlyKd+FTqZzYvdIlYQNmJzqado6t7S/JwUs4EKrAcLwY4W+vNLY6g3OxMJUy IVXeb8MyTmCqDZlqXsQ6k5/h+5VAf6OvWJfMikRQ0W6t3GMa6o4m+pt+g5bCXfoaE8sa KO8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=F7buBfDBa3xtYh+wXDsIuD708fLbtmglyRU6czhdO8I=; b=IdK0X+i4WbP8u94vxqiNHIQQmZK1fskylXVWkU0jbEPd9m4IKpmefpSkm2HchqfCux k/s/sawUj3oQA42gny60OQ18mAReNCEg8xTAlwlrPNyOzGmeZ9Wr3k1hdDa54z5I43c5 mtJgt2+uoCKUBj1oVjyo7+a2Bith4D2oYolJYi9g049fN58ZlS9R/YioNslpb137olfz SfqToYHDQS4PyUBoe7pMlJZ0HIwLBcRmJeaEQAFvlWUYyDc3Kxs+ROohilLMX1e7JaZR DMpgdpOVybDyNv2ySWBfuvF0uxUZZVsz1txKAAvMQN/ZUJTgVqGr9mdyxVWZvWyJY8yz 12JQ== X-Gm-Message-State: AJaThX4gsmUZzHAcC8FUoEPa3pbkGpIapzM9bxZgeto7qdaHFpha9zrz ygyXYPPuT6ngwcG3RDScmykxvoEu X-Received: by 10.80.203.12 with SMTP id g12mr9141259edi.14.1510949159478; Fri, 17 Nov 2017 12:05:59 -0800 (PST) Received: from [192.168.2.62] (p5B3DDB65.dip0.t-ipconnect.de. [91.61.219.101]) by smtp.gmail.com with ESMTPSA id 88sm3098862edq.49.2017.11.17.12.05.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Nov 2017 12:05:58 -0800 (PST) Subject: Re: [PATCH v10 5/8] ARM: dts: sunxi: Restore EMAC changes (boards) To: Corentin Labbe , robh+dt@kernel.org, mark.rutland@arm.com, maxime.ripard@free-electrons.com, wens@csie.org, linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20171031081915.18960-1-clabbe.montjoie@gmail.com> <20171031081915.18960-6-clabbe.montjoie@gmail.com> From: Philipp Rossak Message-ID: Date: Fri, 17 Nov 2017 21:05:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171031081915.18960-6-clabbe.montjoie@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey, Sorry for the bringing this up again. Isn't there a: ethernet0 = &emac; for some boards missing? Best, Philipp (Sorry for sending this to some persons more than once! My Thunderbird sent mails in html and didn't reach the mailing lists. I hope it works now :) ) On 31.10.2017 09:19, Corentin Labbe wrote: > The original dwmac-sun8i DT bindings have some issue on how to handle > integrated PHY and was reverted in last RC of 4.13. > But now we have a solution so we need to get back that was reverted. > > This patch restore all boards DT about dwmac-sun8i > This reverts partially commit fe45174b72ae ("arm: dts: sunxi: Revert EMAC changes") > > Signed-off-by: Corentin Labbe > Acked-by: Florian Fainelli > --- > arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 9 +++++++++ > arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts | 19 +++++++++++++++++++ > arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts | 19 +++++++++++++++++++ > arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts | 7 +++++++ > arch/arm/boot/dts/sun8i-h3-orangepi-2.dts | 8 ++++++++ > arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 8 ++++++++ > arch/arm/boot/dts/sun8i-h3-orangepi-pc-plus.dts | 5 +++++ > arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts | 8 ++++++++ > arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts | 22 ++++++++++++++++++++++ > arch/arm/boot/dts/sun8i-h3-orangepi-plus2e.dts | 16 ++++++++++++++++ > 10 files changed, 121 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts > index b1502df7b509..6713d0f2b3f4 100644 > --- a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts > +++ b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts > @@ -56,6 +56,8 @@ > > aliases { > serial0 = &uart0; > + /* ethernet0 is the H3 emac, defined in sun8i-h3.dtsi */ > + ethernet0 = &emac; > ethernet1 = &xr819; > }; > > @@ -102,6 +104,13 @@ > status = "okay"; > }; > > +&emac { > + phy-handle = <&int_mii_phy>; > + phy-mode = "mii"; > + allwinner,leds-active-low; > + status = "okay"; > +}; > + > &mmc0 { > pinctrl-names = "default"; > pinctrl-0 = <&mmc0_pins_a>; > diff --git a/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts b/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts > index e1dba9ffa94b..f2292deaa590 100644 > --- a/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts > +++ b/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts > @@ -52,6 +52,7 @@ > compatible = "sinovoip,bpi-m2-plus", "allwinner,sun8i-h3"; > > aliases { > + ethernet0 = &emac; > serial0 = &uart0; > serial1 = &uart1; > }; > @@ -111,6 +112,24 @@ > status = "okay"; > }; > > +&emac { > + pinctrl-names = "default"; > + pinctrl-0 = <&emac_rgmii_pins>; > + phy-supply = <®_gmac_3v3>; > + phy-handle = <&ext_rgmii_phy>; > + phy-mode = "rgmii"; > + > + allwinner,leds-active-low; > + status = "okay"; > +}; > + > +&external_mdio { > + ext_rgmii_phy: ethernet-phy@1 { > + compatible = "ethernet-phy-ieee802.3-c22"; > + reg = <0>; > + }; > +}; > + > &ir { > pinctrl-names = "default"; > pinctrl-0 = <&ir_pins_a>; > diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts > index 73766d38ee6c..cfb96da3cfef 100644 > --- a/arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts > +++ b/arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts > @@ -66,6 +66,25 @@ > status = "okay"; > }; > > +&emac { > + pinctrl-names = "default"; > + pinctrl-0 = <&emac_rgmii_pins>; > + phy-supply = <®_gmac_3v3>; > + phy-handle = <&ext_rgmii_phy>; > + phy-mode = "rgmii"; > + > + allwinner,leds-active-low; > + > + status = "okay"; > +}; > + > +&external_mdio { > + ext_rgmii_phy: ethernet-phy@1 { > + compatible = "ethernet-phy-ieee802.3-c22"; > + reg = <7>; > + }; > +}; > + > &ir { > pinctrl-names = "default"; > pinctrl-0 = <&ir_pins_a>; > diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts > index 8d2cc6e9a03f..78f6c24952dd 100644 > --- a/arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts > +++ b/arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts > @@ -46,3 +46,10 @@ > model = "FriendlyARM NanoPi NEO"; > compatible = "friendlyarm,nanopi-neo", "allwinner,sun8i-h3"; > }; > + > +&emac { > + phy-handle = <&int_mii_phy>; > + phy-mode = "mii"; > + allwinner,leds-active-low; > + status = "okay"; > +}; > diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts > index 1bf51802f5aa..b20be95b49d5 100644 > --- a/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts > +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts > @@ -54,6 +54,7 @@ > aliases { > serial0 = &uart0; > /* ethernet0 is the H3 emac, defined in sun8i-h3.dtsi */ > + ethernet0 = &emac; > ethernet1 = &rtl8189; > }; > > @@ -117,6 +118,13 @@ > status = "okay"; > }; > > +&emac { > + phy-handle = <&int_mii_phy>; > + phy-mode = "mii"; > + allwinner,leds-active-low; > + status = "okay"; > +}; > + > &ir { > pinctrl-names = "default"; > pinctrl-0 = <&ir_pins_a>; > diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts > index a1c6ff6fd05d..82e5d28cd698 100644 > --- a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts > +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts > @@ -52,6 +52,7 @@ > compatible = "xunlong,orangepi-one", "allwinner,sun8i-h3"; > > aliases { > + ethernet0 = &emac; > serial0 = &uart0; > }; > > @@ -97,6 +98,13 @@ > status = "okay"; > }; > > +&emac { > + phy-handle = <&int_mii_phy>; > + phy-mode = "mii"; > + allwinner,leds-active-low; > + status = "okay"; > +}; > + > &mmc0 { > pinctrl-names = "default"; > pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin>; > diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-pc-plus.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-pc-plus.dts > index 8b93f5c781a7..a10281b455f5 100644 > --- a/arch/arm/boot/dts/sun8i-h3-orangepi-pc-plus.dts > +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-pc-plus.dts > @@ -53,6 +53,11 @@ > }; > }; > > +&emac { > + /* LEDs changed to active high on the plus */ > + /delete-property/ allwinner,leds-active-low; > +}; > + > &mmc1 { > pinctrl-names = "default"; > pinctrl-0 = <&mmc1_pins_a>; > diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts > index d0b80fda2f6b..6d98bcfbe877 100644 > --- a/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts > +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts > @@ -52,6 +52,7 @@ > compatible = "xunlong,orangepi-pc", "allwinner,sun8i-h3"; > > aliases { > + ethernet0 = &emac; > serial0 = &uart0; > }; > > @@ -117,6 +118,13 @@ > status = "okay"; > }; > > +&emac { > + phy-handle = <&int_mii_phy>; > + phy-mode = "mii"; > + allwinner,leds-active-low; > + status = "okay"; > +}; > + > &ir { > pinctrl-names = "default"; > pinctrl-0 = <&ir_pins_a>; > diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts > index 72ca01b93f1b..cbc499b04de4 100644 > --- a/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts > +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts > @@ -47,6 +47,10 @@ > model = "Xunlong Orange Pi Plus / Plus 2"; > compatible = "xunlong,orangepi-plus", "allwinner,sun8i-h3"; > > + aliases { > + ethernet0 = &emac; > + }; > + > reg_gmac_3v3: gmac-3v3 { > compatible = "regulator-fixed"; > regulator-name = "gmac-3v3"; > @@ -74,6 +78,24 @@ > status = "okay"; > }; > > +&emac { > + pinctrl-names = "default"; > + pinctrl-0 = <&emac_rgmii_pins>; > + phy-supply = <®_gmac_3v3>; > + phy-handle = <&ext_rgmii_phy>; > + phy-mode = "rgmii"; > + > + allwinner,leds-active-low; > + status = "okay"; > +}; > + > +&external_mdio { > + ext_rgmii_phy: ethernet-phy@1 { > + compatible = "ethernet-phy-ieee802.3-c22"; > + reg = <0>; > + }; > +}; > + > &mmc2 { > pinctrl-names = "default"; > pinctrl-0 = <&mmc2_8bit_pins>; > diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-plus2e.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-plus2e.dts > index 97920b12a944..6dbf7b2e0c13 100644 > --- a/arch/arm/boot/dts/sun8i-h3-orangepi-plus2e.dts > +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-plus2e.dts > @@ -61,3 +61,19 @@ > gpio = <&pio 3 6 GPIO_ACTIVE_HIGH>; /* PD6 */ > }; > }; > + > +&emac { > + pinctrl-names = "default"; > + pinctrl-0 = <&emac_rgmii_pins>; > + phy-supply = <®_gmac_3v3>; > + phy-handle = <&ext_rgmii_phy>; > + phy-mode = "rgmii"; > + status = "okay"; > +}; > + > +&external_mdio { > + ext_rgmii_phy: ethernet-phy@1 { > + compatible = "ethernet-phy-ieee802.3-c22"; > + reg = <1>; > + }; > +}; > From 1582760702643866249@xxx Tue Oct 31 08:23:51 +0000 2017 X-GM-THRID: 1582760702643866249 X-Gmail-Labels: Inbox,Category Forums