From: Johannes Weiner <hannes@saeurebad.de>
To: "Mike Frysinger" <vapier.adi@gmail.com>
Cc: "Alan Cox" <alan@lxorguk.ukuu.org.uk>, "Marc Pignat" <marc.pignat@hevs.ch>,
       wim@iguana.be, linux-kernel@vger.kernel.org
Subject: printk-wrapper with sectionized string constants [was: Re: [RFC, PATCH] watchdog on gpio]
References: <200801101611.08867.marc.pignat@hevs.ch>
	<8bd0f97a0801140004q6a32c2ceh397a2208d3012f0e@mail.gmail.com>
	<20080114090329.6efa2921@lxorguk.ukuu.org.uk>
	<8bd0f97a0801140128i2ebf9236uabe0e0b8cf15fbe@mail.gmail.com>
	<20080114092905.227c5a38@lxorguk.ukuu.org.uk>
	<8bd0f97a0801140145s5e13083ej926aa9d5f87e3a99@mail.gmail.com>
	<87zlv8k1w0.fsf@saeurebad.de>
	<8bd0f97a0801140503t484ab61clcf41f4e4ea913fe4@mail.gmail.com>
Date: Mon, 14 Jan 2008 14:56:52 +0100
In-Reply-To: <8bd0f97a0801140503t484ab61clcf41f4e4ea913fe4@mail.gmail.com>
	(Mike Frysinger's message of "Mon, 14 Jan 2008 08:03:29 -0500")
Message-ID: <87prw4jysb.fsf_-_@saeurebad.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1191
Lines: 41

Hi,

"Mike Frysinger" <vapier.adi@gmail.com> writes:
>> How about:
>>
>> #define init_printk(fmt, args...) ({            \
>>         static const __init char __fmt[] = fmt; \
>>         printk(__fmt, args);                    \
>> })
>>
>> Now it returns the printk result.
>
> i wasnt really worried about that ... i was worried about other random
> things i may have missed

Ok.

> your dropping of ## wont work as you need gcc to expand args and take
> away the , in the simple 1 arg case:
> init_printk("MOO");

Whoops, totally oversaw this one.  Of course, this must be in.

Perhaps an even more generic solution would be good, like this:

#define section_printk(sect, fmt, args...) ({		\
	static const sect char __fmt[] = fmt;		\
        printk(__fmt, ## args);				\
})

And then just have convenience wrappers like {,dev}init_printk, ... etc.

Can someone please shout at us if there is a fundamental problem with
this approach?

	Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/