Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Arvind Yadav <arvind.yadav.cs@gmail.com>
To:     isdn@linux-pingi.de, davem@davemloft.net,
        stephen@networkplumber.org, johannes.berg@intel.com
Cc:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH 03/12] isdn: hisax: Fix pnp_irq's error checking for setup_diva_isapnp
Date:   Thu, 16 Nov 2017 09:57:20 +0530
Message-Id: <6e647b3996ac5e67c40f52c3ce2c55d8b044f44e.1510805781.git.arvind.yadav.cs@gmail.com>
In-Reply-To: <cover.1510805781.git.arvind.yadav.cs@gmail.com>
References: <cover.1510805781.git.arvind.yadav.cs@gmail.com>
In-Reply-To: <cover.1510805781.git.arvind.yadav.cs@gmail.com>
References: <cover.1510805781.git.arvind.yadav.cs@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

The pnp_irq() function returns -1 if an error occurs.
pnp_irq() error checking for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/isdn/hisax/diva.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/isdn/hisax/diva.c b/drivers/isdn/hisax/diva.c
index 3fc94e7..bed749c 100644
--- a/drivers/isdn/hisax/diva.c
+++ b/drivers/isdn/hisax/diva.c
@@ -1094,7 +1094,7 @@ static int setup_diva_isapnp(struct IsdnCard *card)
 				}
 				card->para[1] = pnp_port_start(pnp_d, 0);
 				card->para[0] = pnp_irq(pnp_d, 0);
-				if (!card->para[0] || !card->para[1]) {
+				if (card->para[0] == -1 || !card->para[1]) {
 					printk(KERN_ERR "Diva PnP:some resources are missing %ld/%lx\n",
 					       card->para[0], card->para[1]);
 					pnp_disable_dev(pnp_d);
-- 
1.9.1


From 1584360728827224247@xxx Sat Nov 18 00:15:35 +0000 2017
X-GM-THRID: 1584360728827224247
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread