Received: by 10.223.164.202 with SMTP id h10csp2179168wrb; Thu, 16 Nov 2017 10:36:38 -0800 (PST) X-Google-Smtp-Source: AGs4zMYH7ybPJEKR8oWJN32ByY7stQUIb6S1VnLcQXlguo0NZgrSfqX0AKVjPDlmyTE/pTWmSZrQ X-Received: by 10.98.144.129 with SMTP id q1mr2858948pfk.38.1510857398877; Thu, 16 Nov 2017 10:36:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510857398; cv=none; d=google.com; s=arc-20160816; b=rPRSsIRzUJourRb4dbQJ290eFaS1u6vXAzvDLfDDRMLqUGLesSyFRin7ROH70IzWif gbJaUTbDHKa5eLxvb6GQEnSeF/1VK0kwPuln2rgqTHykkuS9w6Si8rGTF15rEStSHa9w IZtWlV5eR2wK57Dpvoye89ulySeBmGXI2QDQFKp3Oz2GD2G1sfL6c2G2R30vWpxPpymv rdflZqN8Z4zS2Bg/pKbiwTAKz95Efx3nTWC4K3kY7VMYKBUPW0S3/MiArmP147xsbrvn 1jbpa5HoYlWX1QAc1pWAGvsi0HwgKnnhyfhSXv5OZXoGHPWuTydrC4j0E/rGsAcomAb8 LlvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=jujY6yr6KNpJtscblm8uSbFyiOTpHrjQqW7xjCvcJ/M=; b=o2HtnvNuLPg6xTjM6p0wxD4oQ/X4ouzM6CsPMhnkZVSHsMRVXp6iye16otHlCftjq3 fJrU++mJNTGEN4C0TcWAbhtgsHTfOfo4VsbeTjr78XtEZPGEEqjTFsb+RcFAfJXiFqv9 vL2SPgRhBptpAWllDzzzhMOnRhUNaDNk1cphuj08yp7CxxUCMQvSrTLILE6rkqBxPD0n 4D0h8jcf6M+VtfbedUYSBBQy9BpamWoe7PF0uEUA7hMsf5QGTeIveadYpynKRvDy1Pvg RAdFJ3dE3WjK39NfgJV52ThmpJpWJf5++spxD8YEX/ub+jP3olOzx4T/D3SOupe/F387 rNCw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w9si1272894plp.220.2017.11.16.10.36.26; Thu, 16 Nov 2017 10:36:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935289AbdKPOAg (ORCPT + 91 others); Thu, 16 Nov 2017 09:00:36 -0500 Received: from mga04.intel.com ([192.55.52.120]:25908 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935163AbdKPN57 (ORCPT ); Thu, 16 Nov 2017 08:57:59 -0500 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2017 06:07:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,399,1505804400"; d="scan'208";a="2130878" Received: from elena-thinkpad-x230.fi.intel.com ([10.237.72.87]) by FMSMGA003.fm.intel.com with ESMTP; 15 Nov 2017 06:07:43 -0800 From: Elena Reshetova To: mingo@redhat.com Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, peterz@infradead.org, gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk, tj@kernel.org, hannes@cmpxchg.org, lizefan@huawei.com, acme@kernel.org, alexander.shishkin@linux.intel.com, eparis@redhat.com, akpm@linux-foundation.org, arnd@arndb.de, luto@kernel.org, keescook@chromium.org, tglx@linutronix.de, dvhart@infradead.org, ebiederm@xmission.com, linux-mm@kvack.org, axboe@kernel.dk, Elena Reshetova Subject: [PATCH 00/16] v6 kernel core pieces refcount conversions Date: Wed, 15 Nov 2017 16:03:24 +0200 Message-Id: <1510754620-27088-1-git-send-email-elena.reshetova@intel.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Changes in v6: * memory ordering differences are outlined in each patch together with potential problematic areas. Note: I didn't include any statements in individual patches on why I think the memory ordering changes do not matter in that particular case since ultimately these are only known by maintainers (unless explicitly documented) and very hard to figure out reliably from the code. Therefore maintainers are expected to double check the specific pointed functions and make the end decision. * rebase on top of today's linux-next/master Changes in v5: * Kees catched that the following changes in perf_event_context.refcount and futex_pi_state.refcount are not correct now when ARCH_HAS_REFCOUNT is enabled: - WARN_ON(!atomic_inc_not_zero(refcount)); + refcount_inc(refcount); So they are now changed back to using refcount_inc_not_zero. Changes in v4: * just rebase and corrections on linux-next/master Changes in v3: * SoB chain corrected * minor corrections based on v2 feedback * rebase on linux-next/master as of today Changes in v2: * dropped already merged patches * rebase on top of linux-next/master * Now by default refcount_t = atomic_t (*) and uses all atomic standard operations unless CONFIG_REFCOUNT_FULL is enabled. This is a compromise for the systems that are critical on performance (such as net) and cannot accept even slight delay on the refcounter operations. This series, for core kernel components, replaces atomic_t reference counters with the new refcount_t type and API (see include/linux/refcount.h). By doing this we prevent intentional or accidental underflows or overflows that can led to use-after-free vulnerabilities. The patches are fully independent and can be cherry-picked separately. If there are no objections to the patches, please merge them via respective trees. Elena Reshetova (16): futex: convert futex_pi_state.refcount to refcount_t sched: convert sighand_struct.count to refcount_t sched: convert signal_struct.sigcnt to refcount_t sched: convert user_struct.__count to refcount_t sched: convert numa_group.refcount to refcount_t sched/task_struct: convert task_struct.usage to refcount_t sched/task_struct: convert task_struct.stack_refcount to refcount_t perf: convert perf_event_context.refcount to refcount_t perf/ring_buffer: convert ring_buffer.refcount to refcount_t perf/ring_buffer: convert ring_buffer.aux_refcount to refcount_t uprobes: convert uprobe.ref to refcount_t nsproxy: convert nsproxy.count to refcount_t groups: convert group_info.usage to refcount_t creds: convert cred.usage to refcount_t kcov: convert kcov.refcount to refcount_t bdi: convert bdi_writeback_congested.refcnt from atomic_t to refcount_t fs/exec.c | 4 ++-- fs/proc/task_nommu.c | 2 +- include/linux/backing-dev-defs.h | 3 ++- include/linux/backing-dev.h | 4 ++-- include/linux/cred.h | 13 ++++++------ include/linux/init_task.h | 7 +++--- include/linux/nsproxy.h | 6 +++--- include/linux/perf_event.h | 3 ++- include/linux/sched.h | 5 +++-- include/linux/sched/signal.h | 5 +++-- include/linux/sched/task.h | 4 ++-- include/linux/sched/task_stack.h | 2 +- include/linux/sched/user.h | 5 +++-- kernel/cred.c | 46 ++++++++++++++++++++-------------------- kernel/events/core.c | 18 ++++++++-------- kernel/events/internal.h | 5 +++-- kernel/events/ring_buffer.c | 8 +++---- kernel/events/uprobes.c | 8 +++---- kernel/fork.c | 24 ++++++++++----------- kernel/futex.c | 15 +++++++------ kernel/groups.c | 2 +- kernel/kcov.c | 9 ++++---- kernel/nsproxy.c | 6 +++--- kernel/sched/fair.c | 12 +++++------ kernel/user.c | 8 +++---- mm/backing-dev.c | 14 ++++++------ 26 files changed, 125 insertions(+), 113 deletions(-) -- 2.7.4 From 1584185678083644048@xxx Thu Nov 16 01:53:13 +0000 2017 X-GM-THRID: 1584147584988517853 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread